upress Werror introduced by no override #86786 on bool initialized()#89687
Merged
jeanschmidt merged 1 commit intomasterfrom Nov 28, 2022
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89687
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 32f72d7: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
Contributor
|
Merge bot should have been used to commit the change |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…ol initialized()` (pytorch#89687)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is forward fix for : #86786
Which generates following error when compiled with
-Werror:See declaration of CUDAAllocator:
https://github.com/pytorch/pytorch/blob/master/c10/cuda/CUDACachingAllocator.h#L186