Use isinstance test rather than exact type test for wrap to fake by ezyang · Pull Request #89671 · pytorch/pytorch

ezyang · 2022-11-25T01:22:08Z

Stack from ghstack (oldest at bottom):

I'm not sure why we did an exact test originally. Let's find out!

Signed-off-by: Edward Z. Yang ezyang@fb.com

cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire

I'm not sure why we did an exact test originally. Let's find out! Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]

pytorch-bot · 2022-11-25T01:22:10Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89671

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit 86b2565:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…o fake" I'm not sure why we did an exact test originally. Let's find out! Signed-off-by: Edward Z. Yang <ezyangfb.com> cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]

ezyang · 2022-11-25T21:36:47Z

@pytorchbot merge -f "ci failures only on master"

pytorchmergebot · 2022-11-25T21:38:24Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2022-11-25T21:38:39Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 963c8098655072c1c6dc2354dba8d3b174289810 returned non-zero exit code 1

Auto-merging functorch/_src/aot_autograd.py
CONFLICT (content): Merge conflict in functorch/_src/aot_autograd.py
error: could not apply 963c809865... Make aot_module_simplified accept fake tensors
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Details for Dev Infra team

Raised by workflow job

…o fake" I'm not sure why we did an exact test originally. Let's find out! Signed-off-by: Edward Z. Yang <ezyangfb.com> cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]

I'm not sure why we did an exact test originally. Let's find out! Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: 7790480 Pull Request resolved: #89671

ezyang · 2022-11-25T21:57:21Z

@pytorchbot merge

pytorchmergebot · 2022-11-25T21:59:09Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

ezyang · 2022-11-25T22:05:57Z

~~Sooooooo it turns out this causes an accuracy failure on BERT_pytorch with dynamic shapes aot eager! None of our asserts trigger.~~ might be wrong, retesting

pytorchmergebot · 2022-11-25T22:06:42Z

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

…o fake" I'm not sure why we did an exact test originally. Let's find out! Signed-off-by: Edward Z. Yang <ezyangfb.com> cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]

ezyang · 2022-11-28T18:36:07Z

@pytorchbot merge -f "master failures and flaky ci only"

pytorchmergebot · 2022-11-28T18:39:04Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…orch#89671) I'm not sure why we did an exact test originally. Let's find out! Signed-off-by: Edward Z. Yang <ezyang@fb.com> Pull Request resolved: pytorch#89671 Approved by: https://github.com/voznesenskym

Use isinstance test rather than exact type test for wrap to fake

feeac4f

I'm not sure why we did an exact test originally. Let's find out! Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]

ezyang mentioned this pull request Nov 25, 2022

xfail maml test, instead of running it without fake tensor prop #89645

Closed

github-actions bot added ciflow/inductor module: dynamo labels Nov 25, 2022

github-actions bot requested review from Chillee, SherlockNoMad, albanD, anjali411, antoniojkim, bdhirsh, miladm, voznesenskym and wconstab November 25, 2022 01:22

ezyang mentioned this pull request Nov 25, 2022

[UPDATED PROTOTYPE] Use dynamo fake tensor mode in aot_autograd, move aot_autograd compilation to lowering time #89672

Closed

ezyang added topic: not user facing topic category release notes: dynamo labels Nov 25, 2022

ezyang added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 25, 2022

ezyang mentioned this pull request Nov 25, 2022

Don't suppress exceptions from backends #89656

Closed

voznesenskym approved these changes Nov 25, 2022

View reviewed changes

ezyang mentioned this pull request Nov 26, 2022

Factor input deduplication into a separate function #89701

Closed

ezyang mentioned this pull request Nov 26, 2022

Add debug asserts to AOTAutograd for input consistency with compilation #89702

Closed

voznesenskym mentioned this pull request Nov 26, 2022

Unit test fixes #89703

Closed

voznesenskym mentioned this pull request Nov 27, 2022

Add simple assert to detect fake tensors on modules #89722

Closed

ezyang mentioned this pull request Nov 28, 2022

Refactor how AOTAutograd backends are defined #89736

Closed

voznesenskym mentioned this pull request Nov 28, 2022

Get CI passing #89773

Closed

pytorchmergebot added the Merged label Nov 28, 2022

pytorchmergebot closed this in cf91e36 Nov 28, 2022

facebook-github-bot deleted the gh/ezyang/1590/head branch June 8, 2023 16:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use isinstance test rather than exact type test for wrap to fake#89671

Use isinstance test rather than exact type test for wrap to fake#89671
ezyang wants to merge 9 commits intogh/ezyang/1590/basefrom
gh/ezyang/1590/head

ezyang commented Nov 25, 2022 •

edited by voznesenskym

Loading

Uh oh!

pytorch-bot bot commented Nov 25, 2022 •

edited

Loading

Uh oh!

ezyang commented Nov 25, 2022

Uh oh!

pytorchmergebot commented Nov 25, 2022

Uh oh!

pytorchmergebot commented Nov 25, 2022

Uh oh!

ezyang commented Nov 25, 2022

Uh oh!

pytorchmergebot commented Nov 25, 2022

Uh oh!

ezyang commented Nov 25, 2022 •

edited

Loading

Uh oh!

pytorchmergebot commented Nov 25, 2022

Uh oh!

ezyang commented Nov 28, 2022

Uh oh!

pytorchmergebot commented Nov 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ezyang commented Nov 25, 2022 • edited by voznesenskym Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Nov 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89671

❌ 2 Failures

Uh oh!

ezyang commented Nov 25, 2022

Uh oh!

pytorchmergebot commented Nov 25, 2022

Merge started

Uh oh!

pytorchmergebot commented Nov 25, 2022

Merge failed

Uh oh!

ezyang commented Nov 25, 2022

Uh oh!

pytorchmergebot commented Nov 25, 2022

Merge started

Uh oh!

ezyang commented Nov 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorchmergebot commented Nov 25, 2022

Uh oh!

ezyang commented Nov 28, 2022

Uh oh!

pytorchmergebot commented Nov 28, 2022

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ezyang commented Nov 25, 2022 •

edited by voznesenskym

Loading

pytorch-bot bot commented Nov 25, 2022 •

edited

Loading

ezyang commented Nov 25, 2022 •

edited

Loading