Skip to content

Switch use_fake_tensor to True by default#89663

Closed
ezyang wants to merge 4 commits intogh/ezyang/1583/basefrom
gh/ezyang/1583/head
Closed

Switch use_fake_tensor to True by default#89663
ezyang wants to merge 4 commits intogh/ezyang/1583/basefrom
gh/ezyang/1583/head

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Nov 24, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Signed-off-by: Edward Z. Yang ezyang@fb.com

@ezyang
Switch use_fake_tensor to True by default
1bca1e3 
Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 24, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89663

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit db8d288:

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on master:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Nov 24, 2022
@ezyang
Switch use_fake_tensor to True by default
e3093f0 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: 60ec708
Pull Request resolved: #89663
@ezyang ezyang mentioned this pull request Nov 25, 2022
Closed
@ezyang ezyang mentioned this pull request Nov 28, 2022
Closed
@ezyang
Copy link
Contributor Author

ezyang commented Nov 28, 2022

This needs some work to get through the test failures

@albanD albanD removed their request for review November 28, 2022 14:54
@ezyang
Update on "Switch use_fake_tensor to True by default"
f6b94f4 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Dec 16, 2022
@ezyang
Switch use_fake_tensor to True by default
61fc931 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: 63376e8
Pull Request resolved: #89663
@ezyang
Update on "Switch use_fake_tensor to True by default"
108f42d 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
@ezyang
Update on "Switch use_fake_tensor to True by default"
db8d288 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Dec 18, 2022
@ezyang
Switch use_fake_tensor to True by default
60edfea 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: 763075d
Pull Request resolved: #89663
@ezyang ezyang added topic: bc breaking topic category release notes: torch.func release notes category for torch.vmap or torch.func.* APIs ciflow/trunk Trigger trunk jobs on your pull request labels Dec 18, 2022
@ezyang
Copy link
Contributor Author

ezyang commented Dec 18, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 18, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 18, 2022

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / cuda11.6-py3.10-gcc7-sm86 / test (default, 2, 4, linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor Author

ezyang commented Dec 19, 2022

@pytorchbot merge -f "flaky ci only"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 19, 2022

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1583/head branch June 8, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anjali411 anjali411 anjali411 approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@Chillee Chillee Awaiting requested review from Chillee

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@wconstab wconstab Awaiting requested review from wconstab

+1 more reviewer

@Morgan77523 Morgan77523 Morgan77523 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: torch.func release notes category for torch.vmap or torch.func.* APIs topic: bc breaking topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ezyang @pytorchmergebot @anjali411 @Morgan77523