Closed
Conversation
Contributor
Author
|
Some simple examples of broken cases: |
Contributor
Author
|
Corresponding numpy behavior: |
Booleaning indexing was special cased to handle a single boolean value, but didn't generally work given multiple booleans. This PR unifies the behavior with slicing. Note that only 'True' and torch.tensor(True) behave like NumPy due to the lack of n-dimensional empty tensors. The corresponding tests for false values have been added, but are guarded behind a flag until we add n-dimensional empty tensors.
8257d70 to
2b8d75c
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Member
|
BTW, does this fix #6773 ? |
Contributor
Author
|
@fmassa doesn't appear to fix that. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
@pytorchbot retest this please. |
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Booleaning indexing was special cased to handle a single boolean value, but didn't generally work given multiple booleans. This PR unifies the behavior with slicing. Note that only 'True' and torch.tensor(True) behave like NumPy due to the lack of n-dimensional empty tensors. The corresponding tests for false values have been added, but are guarded behind a flag until we add n-dimensional empty tensors. Closes pytorch#8920 Reviewed By: ezyang Differential Revision: D8661876 Pulled By: gchanan fbshipit-source-id: 0dc8a45a303aa41f729d04ab8908cfaf2e3ce3d7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Booleaning indexing was special cased to handle a single boolean value, but didn't generally work given multiple booleans.
This PR unifies the behavior with slicing. Note that only 'True' and torch.tensor(True) behave like NumPy due to the lack of n-dimensional empty tensors.
The corresponding tests for false values have been added, but are guarded behind a flag until we add n-dimensional empty tensors.