[dynamo] NNModuleVariable traces into call_function#89015
Closed
wconstab wants to merge 3 commits intogh/wconstab/37/basefrom
Closed
[dynamo] NNModuleVariable traces into call_function#89015wconstab wants to merge 3 commits intogh/wconstab/37/basefrom
wconstab wants to merge 3 commits intogh/wconstab/37/basefrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
nature of nn.modules in dynamo and make graphs with nn.Module
vs user code more consistent
UnspecializedNNModuleVaraible upon mutation. This specialization
is thought to be important for performance (reduced guards,
ability of backends to specialize on parameters, etc)
cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire