Revert "Revert "Put Python Dispatcher cache in dict, clear it on new registrations. (#88329)""#88489
Closed
ezyang wants to merge 2 commits intogh/ezyang/1498/basefrom
Closed
Revert "Revert "Put Python Dispatcher cache in dict, clear it on new registrations. (#88329)""#88489ezyang wants to merge 2 commits intogh/ezyang/1498/basefrom
ezyang wants to merge 2 commits intogh/ezyang/1498/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88489
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 67d132a: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
albanD
approved these changes
Nov 4, 2022
ezyang
commented
Nov 4, 2022
| setattr(self, attr, r) | ||
| final_key = resolve_key(self, key) | ||
| r = self.py_kernels.get(final_key, final_key) | ||
| self._dispatch_cache[key] = r |
Contributor
Author
There was a problem hiding this comment.
This incorrectly was final_key in the previous diff
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
…registrations. (pytorch#88329)"" (pytorch#88489) The bug was that I was accidentally caching at the wrong key name, so we were never actually hitting the cache. I've renamed the resolved key to final_key to avoid shadowing in this way. This reverts commit 410ce96. Pull Request resolved: pytorch#88489 Approved by: https://github.com/albanD
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…registrations. (pytorch#88329)"" (pytorch#88489) The bug was that I was accidentally caching at the wrong key name, so we were never actually hitting the cache. I've renamed the resolved key to final_key to avoid shadowing in this way. This reverts commit 410ce96. Pull Request resolved: pytorch#88489 Approved by: https://github.com/albanD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The bug was that I was accidentally caching at the wrong key name, so
we were never actually hitting the cache. I've renamed the resolved
key to final_key to avoid shadowing in this way.
This reverts commit 410ce96.