[Ready for Review] Better fix for NCCL + sccache#8829
Merged
soumith merged 4 commits intopytorch:masterfrom Jun 25, 2018
Merged
[Ready for Review] Better fix for NCCL + sccache#8829soumith merged 4 commits intopytorch:masterfrom
soumith merged 4 commits intopytorch:masterfrom
Conversation
Contributor
Author
|
@pytorchbot retest this please |
1 similar comment
Contributor
Author
|
@pytorchbot retest this please |
Collaborator
|
Just to bring this line to attention, not sure if it matters: Also, I believe the original method of temporarily writing |
ssnl
reviewed
Jun 25, 2018
| @@ -217,19 +212,13 @@ function build_nccl() { | |||
| -DCMAKE_CXX_FLAGS="$C_FLAGS $CPP_FLAGS $USER_CFLAGS" \ | |||
| -DCMAKE_SHARED_LINKER_FLAGS="$USER_LDFLAGS" \ | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
Thanks @ssnl! I believe this should be the right fix now. |
soumith
approved these changes
Jun 25, 2018
Collaborator
|
cc: @orionr we modified third_party/nccl here |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 27, 2018
Summary: Changes (were merged) in #8834 and #8829 (cc yf225 ) were lost in 9ec0a2a#diff-6997846ce6daf0c271e2db9ef0508551. This PR resubmits them. Closes #8948 Differential Revision: D8665760 Pulled By: SsnL fbshipit-source-id: 15514021fa79e6b908ea665dd6cb464b3ea00ab0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sccachewas stuck when compiling NCCL likely becauseNUM_JOBSwas not set correctly. This PR tests this hypothesis.