Closed
Conversation
Contributor
|
There are probably files that we don't want to put in the PR. Can we rebase onto master, run |
617374a to
b75c77b
Compare
Contributor
Author
|
@yf225 Thank you! I think the new commit should have those files removed. |
0dbb189 to
728c173
Compare
Contributor
Author
|
Revising test cases for Clip op |
Contributor
Author
|
Adding export support for hardtanh to clip in onnx |
3006e4f to
05d362b
Compare
HardtanhGradient CPU Op updated to only use output (Y) not input (X) Finished initial GPU Implementation of Hardtanh and HardtanhGradient Ops. Moving on to tests. Hardtanh tests finished except reference function Removed hardtanh_op_test, added hardtanh tests to activation_ops_test Made input variables const, switched to using fmaxf and fminf, and better utilized macros. Updated const access modifiers for hardtanh op
Member
|
@pytorchbot retest this please |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
houseroad
approved these changes
Jul 11, 2018
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Added hartanh CPU/GPU Implementations and backend tests to Caffe2 Pull Request resolved: pytorch#8804 Reviewed By: bddppq Differential Revision: D8813987 Pulled By: houseroad fbshipit-source-id: 2480296eab3373425b9e1734a10c009b4f5d3e26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added hartanh CPU/GPU Implementations and backend tests to Caffe2