Skip to content

Turn on UBSAN in the OSS build.#8802

Closed
cpuhrsch wants to merge 4 commits intopytorch:masterfrom
cpuhrsch:ubsancpy
Closed

Turn on UBSAN in the OSS build.#8802
cpuhrsch wants to merge 4 commits intopytorch:masterfrom
cpuhrsch:ubsancpy

Conversation

@cpuhrsch
Copy link
Contributor

Copy of #7643

ezyang and others added 4 commits June 22, 2018 14:11
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
@ssnl
Copy link
Collaborator

ssnl commented Jun 22, 2018

undefined-behavior /var/lib/jenkins/workspace/third_party/protobuf/src/google/protobuf/io/printer.cc:353:12

LOL is it possible top build third party libs without UBSAN?

@cpuhrsch
Copy link
Contributor Author

Closed in favor of #8813

@cpuhrsch cpuhrsch closed this Jun 28, 2018
facebook-github-bot pushed a commit that referenced this pull request Jul 5, 2018
Summary:
Copy of #8802
Closes #8813

Differential Revision: D8707364

Pulled By: yf225

fbshipit-source-id: bc201980b50e9fb44c42a17f898b50d3558fc417
zdevito pushed a commit to zdevito/ATen that referenced this pull request Jul 6, 2018
Summary:
Copy of pytorch/pytorch#8802
Closes pytorch/pytorch#8813

Differential Revision: D8707364

Pulled By: yf225

fbshipit-source-id: bc201980b50e9fb44c42a17f898b50d3558fc417
zdevito pushed a commit to zdevito/ATen that referenced this pull request Jul 13, 2018
Summary:
Copy of pytorch/pytorch#8802
Closes pytorch/pytorch#8813

Differential Revision: D8707364

Pulled By: yf225

fbshipit-source-id: bc201980b50e9fb44c42a17f898b50d3558fc417
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
Summary:
Copy of pytorch#8802
Closes pytorch#8813

Differential Revision: D8707364

Pulled By: yf225

fbshipit-source-id: bc201980b50e9fb44c42a17f898b50d3558fc417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants