Skip to content

optim utils all_gather_into_tensor#87769

Closed
rohan-varma wants to merge 1 commit intomasterfrom
rohan-varma-patch-6
Closed

optim utils all_gather_into_tensor#87769
rohan-varma wants to merge 1 commit intomasterfrom
rohan-varma-patch-6

Conversation

@rohan-varma
Copy link
Contributor

@rohan-varma rohan-varma commented Oct 26, 2022

Fixes #ISSUE_NUMBER

@pytorch-bot pytorch-bot bot added the release notes: distributed (fsdp) release notes category label Oct 26, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 26, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87769

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 1 Pending

As of commit 9c36a97:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

awgu
awgu approved these changes Oct 26, 2022
View reviewed changes
Copy link
Collaborator

@awgu awgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 26, 2022
@rohan-varma
Copy link
Contributor Author

rohan-varma commented Oct 26, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 26, 2022

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022

Hey @rohan-varma.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@rohan-varma @kulinseth
optim utils all_gather_into_tensor (pytorch#87769)
8ce2f8e 
Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch#87769
Approved by: https://github.com/awgu
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@rohan-varma @kulinseth
optim utils all_gather_into_tensor (pytorch#87769)
7dcfbdc 
Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch#87769
Approved by: https://github.com/awgu
@github-actions github-actions bot deleted the rohan-varma-patch-6 branch April 26, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awgu awgu awgu approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@H-Huang H-Huang Awaiting requested review from H-Huang

@kwen2501 kwen2501 Awaiting requested review from kwen2501

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (fsdp) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rohan-varma @pytorchmergebot @awgu