Fix missing weight init and clean up helper#87760
Closed
wconstab wants to merge 2 commits intogh/wconstab/20/basefrom
Closed
Fix missing weight init and clean up helper#87760wconstab wants to merge 2 commits intogh/wconstab/20/basefrom
wconstab wants to merge 2 commits intogh/wconstab/20/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87760
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e277b57: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 26, 2022
[ghstack-poisoned]
This was referenced Oct 26, 2022
davidberard98
approved these changes
Oct 26, 2022
| m = ToyModel(hidden_feat=5).to(self.device) | ||
| inputs = torch.randn(20, 10).to(self.device) | ||
| correct_outputs = m(inputs) | ||
| m, inputs, correct_outputs = self.get_model(hidden_feat=5) |
Contributor
There was a problem hiding this comment.
nit: should we specify the first bucket size here so that the test doesn't fail if the first bucket size changes?
(probably doesn't really matter since this model is so small anyway)
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
Pull Request resolved: pytorch#87760 Approved by: https://github.com/davidberard98
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Pull Request resolved: pytorch#87760 Approved by: https://github.com/davidberard98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):