Skip to content

Couple fixes for argmax/argmin#87758

Closed
ngimel wants to merge 2 commits intomasterfrom
ngimel/argmax
Closed

Couple fixes for argmax/argmin#87758
ngimel wants to merge 2 commits intomasterfrom
ngimel/argmax

Conversation

@ngimel
Copy link
Collaborator

@ngimel ngimel commented Oct 26, 2022

Removes a wrong assert, makes min number of warps = 2 (1 for some reason generates invalid code, triton-lang/triton#802).
Hopefully fixes pytorch/torchdynamo#1743, cc @jansel @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @mreso

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 26, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87758

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures, 1 Pending

As of commit d416635:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ngimel ngimel requested review from desertfire and jansel October 26, 2022 02:25
@github-actions
Copy link
Contributor

This PR needs a label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 26, 2022
@ngimel ngimel added the topic: bug fixes topic category label Oct 26, 2022
@ngimel
Copy link
Collaborator Author

ngimel commented Oct 26, 2022

@pytorchbot merge -f "labels added"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link
Contributor

Hey @ngimel.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
Removes a wrong assert, makes min number of warps = 2 (1 for some reason generates invalid code, triton-lang/triton#802).
Hopefully fixes pytorch/torchdynamo#1743, cc @jansel @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @mreso

Pull Request resolved: pytorch#87758
Approved by: https://github.com/Chillee, https://github.com/soumith
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
Removes a wrong assert, makes min number of warps = 2 (1 for some reason generates invalid code, triton-lang/triton#802).
Hopefully fixes pytorch/torchdynamo#1743, cc @jansel @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @mreso

Pull Request resolved: pytorch#87758
Approved by: https://github.com/Chillee, https://github.com/soumith
@github-actions github-actions bot deleted the ngimel/argmax branch April 26, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: bug fixes topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: RuntimeErrors when using TorchInductor for stable diffusion

4 participants