[inductor] Fix finalization issues when using multiprocessing#87725
Closed
zdevito wants to merge 1 commit intogh/zdevito/199/basefrom
Closed
[inductor] Fix finalization issues when using multiprocessing#87725zdevito wants to merge 1 commit intogh/zdevito/199/basefrom
zdevito wants to merge 1 commit intogh/zdevito/199/basefrom
Conversation
If python was launched with 'spawn' it will not use the standard shutdown methods that concurrent.futures requires. So we register a shutdown with the method it does uses. Without this, shutdown hangs since the workers will not exit. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87725
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 Failures, 5 PendingAs of commit bbb1b2c: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
This PR needs a labelIf your changes are user facing and intended to be a part of release notes, please use a label starting with If not, please add the For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work. |
wconstab
approved these changes
Oct 25, 2022
Contributor
|
@pytorchbot merge -f "CI failures appear unrelated" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
…h#87725) If python was launched with 'spawn' it will not use the standard shutdown methods that concurrent.futures requires. So we register a shutdown with the method it does uses. Without this, shutdown hangs since the workers will not exit. cc @jansel @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 Pull Request resolved: pytorch#87725 Approved by: https://github.com/wconstab
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…h#87725) If python was launched with 'spawn' it will not use the standard shutdown methods that concurrent.futures requires. So we register a shutdown with the method it does uses. Without this, shutdown hangs since the workers will not exit. cc @jansel @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 Pull Request resolved: pytorch#87725 Approved by: https://github.com/wconstab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
If python was launched with 'spawn' it will not use the standard
shutdown methods that concurrent.futures requires. So we register a
shutdown with the method it does uses. Without this, shutdown hangs
since the workers will not exit.
cc @jansel @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305