Skip to content

Many symintifications#87604

Closed
albanD wants to merge 10 commits intogh/albanD/115/basefrom
gh/albanD/115/head
Closed

Many symintifications#87604
albanD wants to merge 10 commits intogh/albanD/115/basefrom
gh/albanD/115/head

Conversation

@albanD
Copy link
Collaborator

@albanD albanD commented Oct 24, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Adds
expand_inplace
conv conv_double_backward
convolution
adaptive_avg_pool2d_symint
_embedding_bag_backward_symint
cudnn_grid_sampler
cuda 32 bit indexing
nll_loss / nll_loss_2d
tensor split
pooling same mode
cudnn_is_acceptable
storage nbytes

@albanD
Many symintifications
d8d1a5a 
[ghstack-poisoned]
@albanD albanD requested a review from soulitzer as a code owner October 24, 2022 15:15
@albanD albanD mentioned this pull request Oct 24, 2022
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 24, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87604

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 54b60ee:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@albanD albanD mentioned this pull request Oct 24, 2022
Closed
@albanD
Copy link
Collaborator Author

albanD commented Oct 24, 2022

Will wait for CI for all the xfail update and make sure everything is tested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2022

This PR needs a label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

bdhirsh
bdhirsh reviewed Oct 24, 2022
View reviewed changes
bdhirsh
bdhirsh reviewed Oct 24, 2022
View reviewed changes
bdhirsh
bdhirsh reviewed Oct 24, 2022
View reviewed changes
aten/src/ATen/native/Pool.h
auto wiggle_room = inputSize % stride - 1;
if (wiggle_room > 0) {
--total_padding;
total_padding = total_padding - 1;
Copy link
Collaborator

@bdhirsh bdhirsh Oct 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's worth implementing operator-- as part of merging to master? (I'll leave it up to you)

Copy link
Contributor

@ezyang ezyang Oct 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems worthwhile. But I'll take a rain check if someone agrees to do ALL of the operator overloads, methodically

Copy link
Collaborator Author

@albanD albanD Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, leaving all the operators for a follow up then.

bdhirsh
bdhirsh reviewed Oct 24, 2022
View reviewed changes
bdhirsh
bdhirsh reviewed Oct 24, 2022
View reviewed changes
bdhirsh
bdhirsh reviewed Oct 24, 2022
View reviewed changes
bdhirsh
bdhirsh reviewed Oct 24, 2022
View reviewed changes
@albanD albanD added the topic: not user facing topic category label Oct 24, 2022
bdhirsh
bdhirsh reviewed Oct 24, 2022
View reviewed changes
@albanD
Update on "Many symintifications"
b1ac6f1 
Adds
expand_inplace
conv conv_double_backward
convolution
adaptive_avg_pool2d_symint
_embedding_bag_backward_symint
cudnn_grid_sampler
cuda 32 bit indexing
nll_loss / nll_loss_2d
tensor split
pooling same mode
cudnn_is_acceptable
storage nbytes


[ghstack-poisoned]
@albanD albanD mentioned this pull request Oct 24, 2022
Closed
@albanD
Update on "Many symintifications"
0f3ae84 
Adds
expand_inplace
conv conv_double_backward
convolution
adaptive_avg_pool2d_symint
_embedding_bag_backward_symint
cudnn_grid_sampler
cuda 32 bit indexing
nll_loss / nll_loss_2d
tensor split
pooling same mode
cudnn_is_acceptable
storage nbytes


[ghstack-poisoned]
@albanD
Update on "Many symintifications"
4a732c1 
Adds
expand_inplace
conv conv_double_backward
convolution
adaptive_avg_pool2d_symint
_embedding_bag_backward_symint
cudnn_grid_sampler
cuda 32 bit indexing
nll_loss / nll_loss_2d
tensor split
pooling same mode
cudnn_is_acceptable
storage nbytes


[ghstack-poisoned]
@albanD
Copy link
Collaborator Author

albanD commented Oct 24, 2022

Everything here looks good except diag, which is weirdly complicated for what I expect

Yes the diag change is a mistake due to a land race with master. Cleaning this up now.

@albanD
Update on "Many symintifications"
bbc13ca 
Adds
expand_inplace
conv conv_double_backward
convolution
adaptive_avg_pool2d_symint
_embedding_bag_backward_symint
cudnn_grid_sampler
cuda 32 bit indexing
nll_loss / nll_loss_2d
tensor split
pooling same mode
cudnn_is_acceptable
storage nbytes


[ghstack-poisoned]
@albanD
Update on "Many symintifications"
19c6715 
Adds
expand_inplace
conv conv_double_backward
convolution
adaptive_avg_pool2d_symint
_embedding_bag_backward_symint
cudnn_grid_sampler
cuda 32 bit indexing
nll_loss / nll_loss_2d
tensor split
pooling same mode
cudnn_is_acceptable
storage nbytes


[ghstack-poisoned]
@albanD
Update on "Many symintifications"
2e46263 
Adds
expand_inplace
conv conv_double_backward
convolution
adaptive_avg_pool2d_symint
_embedding_bag_backward_symint
cudnn_grid_sampler
cuda 32 bit indexing
nll_loss / nll_loss_2d
tensor split
pooling same mode
cudnn_is_acceptable
storage nbytes


[ghstack-poisoned]
This was referenced Oct 24, 2022
Closed
Closed
@albanD
Update on "Many symintifications"
ba57108 
Adds
expand_inplace
conv conv_double_backward
convolution
adaptive_avg_pool2d_symint
_embedding_bag_backward_symint
cudnn_grid_sampler
cuda 32 bit indexing
nll_loss / nll_loss_2d
tensor split
pooling same mode
cudnn_is_acceptable
storage nbytes


[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 25, 2022
@albanD
Update on "Many symintifications"
54b60ee 
Adds
expand_inplace
conv conv_double_backward
convolution
adaptive_avg_pool2d_symint
_embedding_bag_backward_symint
cudnn_grid_sampler
cuda 32 bit indexing
nll_loss / nll_loss_2d
tensor split
pooling same mode
cudnn_is_acceptable
storage nbytes


[ghstack-poisoned]
@weiwangmeta
Copy link
Contributor

weiwangmeta commented Oct 28, 2022

@pytorchbot revert -m "breaking internal builds" -c ghfirst

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 28, 2022

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 28, 2022

@albanD your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Oct 28, 2022
@pytorchmergebot
Revert "Many symintifications (#87604)"
8b4d957 
This reverts commit 777e6a2.

Reverted #87604 on behalf of https://github.com/weiwangmeta due to breaking internal builds
albanD added a commit to albanD/pytorch that referenced this pull request Oct 28, 2022
@albanD
Reland 2 Many symintifications (pytorch#87604)
6a95f54
pytorchmergebot pushed a commit that referenced this pull request Oct 28, 2022
@albanD @pytorchmergebot
Reland 2 Many symintifications (#87604) (#87980)
8a9aca7 
Fixes #ISSUE_NUMBER

Pull Request resolved: #87980
Approved by: https://github.com/ezyang
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@albanD @kulinseth
Many symintifications (pytorch#87604)
66c564f 
Adds
expand_inplace
conv conv_double_backward
convolution
adaptive_avg_pool2d_symint
_embedding_bag_backward_symint
cudnn_grid_sampler
cuda 32 bit indexing
nll_loss / nll_loss_2d
tensor split
pooling same mode
cudnn_is_acceptable
storage nbytes

Pull Request resolved: pytorch#87604
Approved by: https://github.com/ezyang
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@pytorchmergebot @kulinseth
Revert "Many symintifications (pytorch#87604)"
e21aa98 
This reverts commit 777e6a2.

Reverted pytorch#87604 on behalf of https://github.com/weiwangmeta due to breaking internal builds
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@albanD @kulinseth
Reland 2 Many symintifications (pytorch#87604) (pytorch#87980)
929aab7 
Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch#87980
Approved by: https://github.com/ezyang
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@albanD @kulinseth
Many symintifications (pytorch#87604)
d058699 
Adds
expand_inplace
conv conv_double_backward
convolution
adaptive_avg_pool2d_symint
_embedding_bag_backward_symint
cudnn_grid_sampler
cuda 32 bit indexing
nll_loss / nll_loss_2d
tensor split
pooling same mode
cudnn_is_acceptable
storage nbytes

Pull Request resolved: pytorch#87604
Approved by: https://github.com/ezyang
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@pytorchmergebot @kulinseth
Revert "Many symintifications (pytorch#87604)"
e6d228c 
This reverts commit 777e6a2.

Reverted pytorch#87604 on behalf of https://github.com/weiwangmeta due to breaking internal builds
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@albanD @kulinseth
Reland 2 Many symintifications (pytorch#87604) (pytorch#87980)
4581180 
Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch#87980
Approved by: https://github.com/ezyang
@facebook-github-bot facebook-github-bot deleted the gh/albanD/115/head branch June 8, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdhirsh bdhirsh bdhirsh left review comments

@ezyang ezyang ezyang approved these changes

@soulitzer soulitzer Awaiting requested review from soulitzer

@anjali411 anjali411 Awaiting requested review from anjali411

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@Chillee Chillee Awaiting requested review from Chillee

@Krovatkin Krovatkin Awaiting requested review from Krovatkin

@miladm miladm Awaiting requested review from miladm

@wconstab wconstab Awaiting requested review from wconstab

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Reverted topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@albanD @ezyang @weiwangmeta @pytorchmergebot @bdhirsh