Enable mypy check for distributed.py, and fix type errors#87543
Enable mypy check for distributed.py, and fix type errors#87543yhcharles wants to merge 15 commits intogh/yhcharles/3/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87543
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2fa1eca: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
torch/_C/_distributed_c10d.pyi
Outdated
| find_unused_parameters: bool, | ||
| gradient_as_bucket_view: bool, | ||
| expect_sparse_gradients: List[bool] = [], | ||
| bucket_bytes_cap: int = kDefaultBucketBytesCap, |
There was a problem hiding this comment.
instead of having to hardcode the constant here (where it can diverge), you can use an ellipsis instead
ezyang
left a comment
There was a problem hiding this comment.
Thanks! You might want to get someone from distributed to look over too
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Merge failedReason: The following mandatory check(s) failed (Rule Dig deeper by viewing the failures on hud Details for Dev Infra teamRaised by workflow job |
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "breaking internal builds" -c ghfirst |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@yhcharles your PR has been successfully reverted. |
…7543)" This reverts commit 2cc624c. Reverted #87543 on behalf of https://github.com/weiwangmeta due to breaking internal builds
) Pull Request resolved: pytorch#87543 Approved by: https://github.com/fduwjj
…torch#87543)" This reverts commit 2cc624c. Reverted pytorch#87543 on behalf of https://github.com/weiwangmeta due to breaking internal builds
) Pull Request resolved: pytorch#87543 Approved by: https://github.com/fduwjj
…torch#87543)" This reverts commit 2cc624c. Reverted pytorch#87543 on behalf of https://github.com/weiwangmeta due to breaking internal builds
Stack from ghstack (oldest at bottom):