Skip to content

[FSDP][BE] Improve the assert message of sharded load_state_dict#87486

Closed
fegin wants to merge 5 commits intogh/fegin/35/basefrom
gh/fegin/35/head
Closed

[FSDP][BE] Improve the assert message of sharded load_state_dict#87486
fegin wants to merge 5 commits intogh/fegin/35/basefrom
gh/fegin/35/head

Conversation

@fegin
Copy link
Contributor

@fegin fegin commented Oct 21, 2022

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 21, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87486

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures, 6 Pending

As of commit ab8af39:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@awgu awgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

)

from ._fsdp_extensions import _ext_chunk_tensor, _ext_pre_load_state_dict_transform
from ._fsdp_extensions import _extensions as _users_extensions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Maybe better?

Suggested change
from ._fsdp_extensions import _extensions as _users_extensions
from ._fsdp_extensions import _extensions as _user_extensions

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 21, 2022
fegin added a commit that referenced this pull request Oct 21, 2022
fegin added a commit that referenced this pull request Oct 25, 2022
@fegin
Copy link
Contributor Author

fegin commented Oct 26, 2022

@pytorchbot merge -f "The failing test is not related".

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link
Contributor

Hey @fegin.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@facebook-github-bot facebook-github-bot deleted the gh/fegin/35/head branch June 8, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (fsdp) release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants