Skip to content

[DataLoader2] Change serialization wrapper to iterator#87459

Closed
ejguan wants to merge 1 commit intopytorch:masterfrom
ejguan:make_wrapper_iterator
Closed

[DataLoader2] Change serialization wrapper to iterator#87459
ejguan wants to merge 1 commit intopytorch:masterfrom
ejguan:make_wrapper_iterator

Conversation

@ejguan
Copy link
Contributor

@ejguan ejguan commented Oct 21, 2022

This is temporary fix for internal SEV. We have run three different workflows to validate this fix would unblock internal SEV.
And, those are a few following-up tasks:

  • Create reproducible test for multithreading with generator
  • Figure out how to make fullsynciterator is working properly with generator
  • Move Wrapper back to generator if needed

@pytorch-bot pytorch-bot bot added the release notes: dataloader release notes category label Oct 21, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 21, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87459

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 4 Pending

As of commit 814a58c:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@ejguan ejguan force-pushed the make_wrapper_iterator branch from b1ce080 to 9564c0f Compare October 24, 2022 15:55
@ejguan ejguan added the topic: bug fixes topic category label Oct 24, 2022
@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@ejguan ejguan requested a review from NivekT October 24, 2022 15:56
Copy link
Contributor

@NivekT NivekT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 24, 2022
@ejguan ejguan force-pushed the make_wrapper_iterator branch from 9564c0f to 71542f6 Compare October 24, 2022 17:45
@ejguan ejguan force-pushed the make_wrapper_iterator branch from 71542f6 to 814a58c Compare October 24, 2022 18:28
@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
This is temporary fix for internal SEV. We have run three different workflows to validate this fix would unblock internal SEV.
And, those are a few following-up tasks:
- [ ] Create reproducible test for multithreading with generator
- [ ] Figure out how to make fullsynciterator is working properly with generator
- [ ] Move Wrapper back to generator if needed
Pull Request resolved: pytorch#87459
Approved by: https://github.com/NivekT
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
This is temporary fix for internal SEV. We have run three different workflows to validate this fix would unblock internal SEV.
And, those are a few following-up tasks:
- [ ] Create reproducible test for multithreading with generator
- [ ] Figure out how to make fullsynciterator is working properly with generator
- [ ] Move Wrapper back to generator if needed
Pull Request resolved: pytorch#87459
Approved by: https://github.com/NivekT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: dataloader release notes category topic: bug fixes topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants