[Inductor] Convert 0d CPU tensor to scalar during triton codegen#87329
Closed
yanboliang wants to merge 6 commits intopytorch:masterfrom
Closed
[Inductor] Convert 0d CPU tensor to scalar during triton codegen#87329yanboliang wants to merge 6 commits intopytorch:masterfrom
yanboliang wants to merge 6 commits intopytorch:masterfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87329
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 Failures, 4 PendingAs of commit fce492c: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ngimel
reviewed
Oct 20, 2022
Collaborator
|
Does this fix pytorch/torchdynamo#1681 (comment)? Can you add a test with a similar pattern, a mix of cpu and cuda ops? |
ngimel
approved these changes
Oct 20, 2022
Contributor
Author
Yes, it fixed. |
Contributor
Author
|
@pytorchbot merge -f "irrelevant mac failures" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ptillet
pushed a commit
to triton-lang/triton
that referenced
this pull request
Oct 25, 2022
In ```torch._inductor```, we [convert 0d CPU tensor to scalar during triton codegen](pytorch/pytorch#87329), so need add missing triton support for bf16/fp16/fp64.
ptillet
pushed a commit
to triton-lang/triton
that referenced
this pull request
Dec 20, 2022
In ```torch._inductor```, we [convert 0d CPU tensor to scalar during triton codegen](pytorch/pytorch#87329), so need add missing triton support for bf16/fp16/fp64.
pingzhuu
pushed a commit
to siliconflow/triton
that referenced
this pull request
Apr 2, 2024
In ```torch._inductor```, we [convert 0d CPU tensor to scalar during triton codegen](pytorch/pytorch#87329), so need add missing triton support for bf16/fp16/fp64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to address this. We revised to use the codegen approach to handle 0d CPU tensor, which will not support cudagraph any more.
cc @jansel @lezcano @fdrocha @mlazos @soumith @voznesenskym