Skip to content

[allocator] Move getFreeMutex#87237

Closed
zdevito wants to merge 2 commits intogh/zdevito/194/basefrom
gh/zdevito/194/head
Closed

[allocator] Move getFreeMutex#87237
zdevito wants to merge 2 commits intogh/zdevito/194/basefrom
gh/zdevito/194/head

Conversation

@zdevito
Copy link
Contributor

@zdevito zdevito commented Oct 18, 2022 •
edited
Loading

@zdevito
[allocator] Move getFreeMutex
b020782 
It isn't used at all the allocators and this change makes that more clear.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87237

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 5 Pending

As of commit e56cc54:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Oct 18, 2022
@zdevito
Update on "[allocator] Move getFreeMutex"
e56cc54 
It isn't used at all the allocators and this change makes that more clear.

[ghstack-poisoned]
zdevito added a commit that referenced this pull request Oct 18, 2022
@zdevito
[allocator] Move getFreeMutex
00e3692 
It isn't used at all the allocators and this change makes that more clear.

ghstack-source-id: ef2bc10
Pull Request resolved: #87237
This was referenced Oct 19, 2022
Closed
Closed
@zdevito zdevito requested a review from wconstab October 19, 2022 00:38
wconstab
wconstab approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@wconstab wconstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 19, 2022
@zdevito
Copy link
Contributor Author

zdevito commented Oct 19, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 19, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2022

Hey @zdevito.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

jjsjann123 pushed a commit to jjsjann123/nvfuser that referenced this pull request Oct 29, 2022
@zdevito @pytorchmergebot
[allocator] Move getFreeMutex (#87237)
52653f1 
It isn't used at all the allocators and this change makes that more clear.
Pull Request resolved: pytorch/pytorch#87237
Approved by: https://github.com/wconstab
jjsjann123 pushed a commit to jjsjann123/nvfuser that referenced this pull request Nov 10, 2022
@zdevito @pytorchmergebot
[allocator] Move getFreeMutex (#87237)
7a92059 
It isn't used at all the allocators and this change makes that more clear.
Pull Request resolved: pytorch/pytorch#87237
Approved by: https://github.com/wconstab
@facebook-github-bot facebook-github-bot deleted the gh/zdevito/194/head branch June 8, 2023 19:26
@Zhenbin-8 Zhenbin-8 mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wconstab wconstab wconstab approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: jit release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zdevito @pytorchmergebot @wconstab