Adding expm1 to MPS by arnaudstiegler · Pull Request #87147 · pytorch/pytorch

arnaudstiegler · 2022-10-17T22:26:14Z

Fixes #86744

Implementing the new expm1_out_mps function in aten/src/ATen/native/mps/operations/UnaryOps.mm
Adding it to aten/src/ATen/native/native_functions.yaml
Adding it to existing test.test_mps.TestNLLLoss.test_unary_ops

pytorch-bot · 2022-10-17T22:26:16Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87147

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures, 6 Pending

As of commit e5f9c6f:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

linux-foundation-easycla · 2022-10-17T22:26:22Z

The committers listed above are authorized under a signed CLA.

✅ login: arnaudstiegler / name: Arnaud Stiegler (6446ea9, 7814cba, c99d363)

arnaudstiegler · 2022-10-18T02:52:12Z

@kulinseth opening the PR, I don't think there's a way for me to run the test since I don't have a Mac with an M1. I have one doubt about the function but the rest should be pretty straightforward :)

arnaudstiegler · 2022-10-18T02:52:30Z

aten/src/ATen/native/mps/operations/UnaryOps.mm

+  mps::unary_op(self, output, "expm1_out_mps",
+                ^ MPSGraphTensor* (MPSGraph* mpsGraph, MPSGraphTensor* inputTensor) {
+                  MPSGraphTensor* oneTensor = [mpsGraph constantWithScalar:1.0
+                                                       shape:@[@1]


Not sure about the shape here

That's correct.

kulinseth · 2022-10-18T22:56:04Z

@kulinseth opening the PR, I don't think there's a way for me to run the test since I don't have a Mac with an M1. I have one doubt about the function but the rest should be pretty straightforward :)

Yes, I have approved the workflow, it will run on M1 Mac as well.

kulinseth

Looks good. Thanks!

kulinseth · 2022-10-18T22:56:50Z

aten/src/ATen/native/mps/operations/UnaryOps.mm

+  mps::unary_op(self, output, "expm1_out_mps",
+                ^ MPSGraphTensor* (MPSGraph* mpsGraph, MPSGraphTensor* inputTensor) {
+                  MPSGraphTensor* oneTensor = [mpsGraph constantWithScalar:1.0
+                                                       shape:@[@1]


That's correct.

arnaudstiegler · 2022-10-20T17:28:57Z

@kulinseth Let me know if there's anything else I should do!

kulinseth · 2022-10-25T22:54:39Z

@pytorchbot merge

pytorchmergebot · 2022-10-25T22:58:22Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2022-10-25T22:58:23Z

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase by leaving the following comment on this PR:
@pytorchbot rebase

Details for Dev Infra team

Raised by workflow job

kulinseth · 2022-10-25T23:04:08Z

@pytorchbot rebase

pytorchmergebot · 2022-10-25T23:25:13Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2022-10-25T23:25:17Z

Successfully rebased AS/add-expm1-mps onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout AS/add-expm1-mps && git pull --rebase)

kulinseth · 2022-10-26T17:44:03Z

@pytorchbot merge -f "MPS tests are green."

pytorchmergebot · 2022-10-26T17:45:43Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

github-actions · 2022-10-26T17:46:18Z

Hey @arnaudstiegler.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Fixes pytorch#86744 - Implementing the new `expm1_out_mps` function in `aten/src/ATen/native/mps/operations/UnaryOps.mm` - Adding it to `aten/src/ATen/native/native_functions.yaml` - Adding it to existing `test.test_mps.TestNLLLoss.test_unary_ops` Pull Request resolved: pytorch#87147 Approved by: https://github.com/kulinseth

pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Oct 17, 2022

pytorchbot added the open source label Oct 17, 2022

arnaudstiegler marked this pull request as ready for review October 18, 2022 02:50

arnaudstiegler requested a review from kulinseth as a code owner October 18, 2022 02:50

arnaudstiegler commented Oct 18, 2022

View reviewed changes

kulinseth approved these changes Oct 18, 2022

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 18, 2022

aaronabraham311 mentioned this pull request Oct 21, 2022

[MPS] Add support for aten::erfinv.out for MPS backend #86808

Closed

arnaudstiegler added 3 commits October 25, 2022 23:25

op implemented, not tested

b2a3a59

clean

13ece5f

adding shape

e5f9c6f

pytorchmergebot force-pushed the AS/add-expm1-mps branch from c99d363 to e5f9c6f Compare October 25, 2022 23:25

pytorchmergebot added the Merged label Oct 26, 2022

pytorchmergebot closed this in 16e35bd Oct 26, 2022

malfet mentioned this pull request Nov 17, 2022

General MPS op coverage tracking issue #77764

Open

Conversation

arnaudstiegler commented Oct 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87147

❌ 2 Failures, 6 Pending

Uh oh!

linux-foundation-easycla bot commented Oct 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arnaudstiegler commented Oct 18, 2022

Uh oh!

arnaudstiegler Oct 18, 2022

Choose a reason for hiding this comment

Uh oh!

kulinseth Oct 18, 2022

Choose a reason for hiding this comment

Uh oh!

kulinseth commented Oct 18, 2022

Uh oh!

kulinseth left a comment

Choose a reason for hiding this comment

Uh oh!

kulinseth Oct 18, 2022

Choose a reason for hiding this comment

Uh oh!

arnaudstiegler commented Oct 20, 2022

Uh oh!

kulinseth commented Oct 25, 2022

Uh oh!

pytorchmergebot commented Oct 25, 2022

Merge started

Uh oh!

pytorchmergebot commented Oct 25, 2022

Merge failed

Uh oh!

kulinseth commented Oct 25, 2022

Uh oh!

pytorchmergebot commented Oct 25, 2022

Uh oh!

pytorchmergebot commented Oct 25, 2022

Uh oh!

kulinseth commented Oct 26, 2022

Uh oh!

pytorchmergebot commented Oct 26, 2022

Merge started

Uh oh!

github-actions bot commented Oct 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

arnaudstiegler commented Oct 17, 2022 •

edited

Loading

pytorch-bot bot commented Oct 17, 2022 •

edited

Loading

linux-foundation-easycla bot commented Oct 17, 2022 •

edited

Loading