Skip to content

[Docs] Remove outdated comment for sparse all-reduce#87018

Closed
awgu wants to merge 1 commit intopytorch:masterfrom
awgu:sparse_ar_docs
Closed

[Docs] Remove outdated comment for sparse all-reduce#87018
awgu wants to merge 1 commit intopytorch:masterfrom
awgu:sparse_ar_docs

Conversation

@awgu
Copy link
Copy Markdown
Collaborator

@awgu awgu commented Oct 15, 2022

#23917 switched to using allgatherv instead of allgather for gloo sparse all-reduce. This PR removes a comment saying to use allgatherv if available since that has already been done.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Oct 15, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87018

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 73917ee:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@awgu awgu added the topic: not user facing topic category label Oct 15, 2022
@awgu awgu changed the title [Easy] Remove outdated comment for sparse all-reduce [Docs] Remove outdated comment for sparse all-reduce Oct 15, 2022
Copy link
Copy Markdown
Contributor

@H-Huang H-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 17, 2022
@awgu
Copy link
Copy Markdown
Collaborator Author

awgu commented Oct 17, 2022

@pytorchbot rebase -s

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Successfully rebased sparse_ar_docs onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout sparse_ar_docs && git pull --rebase)

@awgu
Copy link
Copy Markdown
Collaborator Author

awgu commented Oct 17, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@awgu awgu deleted the sparse_ar_docs branch November 6, 2022 00:58
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
pytorch#23917 switched to using allgatherv instead of allgather for gloo sparse all-reduce. This PR removes a comment saying to use allgatherv if available since that has already been done.
Pull Request resolved: pytorch#87018
Approved by: https://github.com/H-Huang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (c10d) release notes category topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants