Skip to content

Add some common tools to docker base#86993

Closed
huydhn wants to merge 1 commit intopytorch:masterfrom
huydhn:add-some-common-deps-docker
Closed

Add some common tools to docker base#86993
huydhn wants to merge 1 commit intopytorch:masterfrom
huydhn:add-some-common-deps-docker

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Oct 14, 2022 •
edited
Loading

I always need to install these 2 tools whenever I use Docker manually to debug build and test issues:

  • unzip is to extracted the zipped artifacts from PyTorch CI
  • gdb is to do you know what :)

IMO, it makes sense to have them as part of the container image

@huydhn huydhn requested a review from a team October 14, 2022 21:17
@huydhn huydhn self-assigned this Oct 14, 2022
@huydhn huydhn requested a review from jeffdaily as a code owner October 14, 2022 21:17
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 14, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 14, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86993

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 53bb8e5:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn
Copy link
Contributor Author

huydhn commented Oct 15, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 15, 2022

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 15, 2022

Tried to rebase and push PR #86993, but it was already up to date

@huydhn huydhn mentioned this pull request Oct 15, 2022
Closed
@huydhn huydhn marked this pull request as draft October 15, 2022 00:51
@huydhn
Copy link
Contributor Author

huydhn commented Oct 22, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 22, 2022

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 22, 2022

Successfully rebased add-some-common-deps-docker onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout add-some-common-deps-docker && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the add-some-common-deps-docker branch from fc7cb65 to 53bb8e5 Compare October 22, 2022 01:32
ZainRizvi
ZainRizvi approved these changes Oct 22, 2022
View reviewed changes
Copy link
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all pretty small packages (~10MB combined) so it's a pretty small footprint for ease of debug-ability

.circleci/docker/common/install_base.sh
sudo \
wget \
vim
vim \
Copy link
Contributor

@ZainRizvi ZainRizvi Oct 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need neovim :P (jk, jk)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 22, 2022
@huydhn huydhn marked this pull request as ready for review October 24, 2022 22:41
@huydhn
Copy link
Contributor Author

huydhn commented Oct 24, 2022

@pytorchbot merge -f 'The new check labels workflow fails because this PR does not have its commit'

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 24, 2022

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@huydhn @kulinseth
Add some common tools to docker base (pytorch#86993)
210d11c 
I always need to install these 2 tools whenever I use Docker manually to debug build and test issues:

* unzip is to extracted the zipped artifacts from PyTorch CI
* gdb is to do you know what :)

IMO, it makes sense to have them as part of the container image

Pull Request resolved: pytorch#86993
Approved by: https://github.com/ZainRizvi
@huydhn huydhn deleted the add-some-common-deps-docker branch November 9, 2022 19:41
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@huydhn @kulinseth
Add some common tools to docker base (pytorch#86993)
8d0f13b 
I always need to install these 2 tools whenever I use Docker manually to debug build and test issues:

* unzip is to extracted the zipped artifacts from PyTorch CI
* gdb is to do you know what :)

IMO, it makes sense to have them as part of the container image

Pull Request resolved: pytorch#86993
Approved by: https://github.com/ZainRizvi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZainRizvi ZainRizvi ZainRizvi approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

Assignees

@huydhn huydhn

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged test-config/default topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huydhn @pytorchmergebot @ZainRizvi