[WIP] Add support for VS2022 Windows build.#86591
Closed
Blackhex wants to merge 2 commits intopytorch:masterfrom
Closed
[WIP] Add support for VS2022 Windows build.#86591Blackhex wants to merge 2 commits intopytorch:masterfrom
Blackhex wants to merge 2 commits intopytorch:masterfrom
Conversation
|
|
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86591
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 FailuresAs of commit 8f83926: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
2faa1d9 to
52dbac3
Compare
Collaborator
Author
|
@pytorchbot label ciflow/trunk |
|
Can't add following labels to PR: ciflow/trunk Please ping one of the reviewers for help. |
Collaborator
|
@pytorchbot label ciflow/trunk |
d902d4c to
363a9c2
Compare
b6dca97 to
ef996c5
Compare
1a76c54 to
2949f91
Compare
2949f91 to
9cff0e0
Compare
Blackhex
added a commit
to Blackhex/pytorch-builder
that referenced
this pull request
Nov 18, 2022
8d0a41e to
9cff0e0
Compare
Blackhex
added a commit
to Blackhex/pytorch-builder
that referenced
this pull request
Nov 18, 2022
Blackhex
added a commit
to Blackhex/pytorch-builder
that referenced
this pull request
Nov 18, 2022
27d6c72 to
bf6f6fe
Compare
bf6f6fe to
b0faed7
Compare
b0faed7 to
8f83926
Compare
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
atalman
pushed a commit
to pytorch/test-infra
that referenced
this pull request
Jun 8, 2023
This adds VS 2022 to Windows AMI. The line with [https://aka.ms/](https://aka.ms/) link might be reverted once `vs16.11.21_BuildTools.exe` and `vs17.4.1_BuildTools.exe` files will be uploaded to [https://s3.amazonaws.com/ossci-windows/](https://s3.amazonaws.com/ossci-windows/.). Note that there is a fix of [thread\_local causing fatal error LNK1161: invalid export specification on VS 2022 - Visual Studio Feedback](https://developercommunity.visualstudio.com/t/thread_local-causing-fatal-error-LNK1161/10199441) pending, required e.g. for pytorch/pytorch#89511, which will require another VS 2022 version update. Alternatively, the VS 2022 version installed by this change can be downgraded to 16.3.6 which does not suffer this issue. This is needed to finish pytorch/pytorch#86591
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just WIP PR to check if pipelines will fail or pass.