Reland 3 of Symintify getitem and add the required helper functions (#86207)#86487
Closed
albanD wants to merge 2 commits intogh/albanD/96/basefrom
Closed
Reland 3 of Symintify getitem and add the required helper functions (#86207)#86487albanD wants to merge 2 commits intogh/albanD/96/basefrom
albanD wants to merge 2 commits intogh/albanD/96/basefrom
Conversation
…86207) Note that this might not cover every use of the function (we know it doesn't) But this is enough to get few models passing. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86487
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 211d4de: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 7, 2022
ezyang
approved these changes
Oct 7, 2022
…functions (#86207)" Note that this might not cover every use of the function (we know it doesn't) But this is enough to get few models passing. [ghstack-poisoned]
This was referenced Oct 10, 2022
Closed
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 11, 2022
…86207) (#86487) (#86487) Summary: Note that this might not cover every use of the function (we know it doesn't) But this is enough to get few models passing. Pull Request resolved: #86487 Approved by: https://github.com/ezyang Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/55663b7f8174db5d71d611403078ebcec4075b1a Reviewed By: DanilBaibak Differential Revision: D40232593 Pulled By: DanilBaibak fbshipit-source-id: 6927cce33b26b86793670eaab0e027e90c54f613
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Note that this might not cover every use of the function (we know it doesn't)
But this is enough to get few models passing.