[ONNX] Support quantized::conv1d_relu#85997
[ONNX] Support quantized::conv1d_relu#85997titaiwangms wants to merge 4 commits intogh/AllenTiTaiWang/9/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85997
Note: Links to docs will display an error until the docs builds have been completed. ✅ No Failures, 1 PendingAs of commit c341dfb: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
[ghstack-poisoned]
|
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
According to #38248, quantized::conv1d_relu shares packing parameters with Conv2D (kspatialDim is also 2), and needs a different unpacking way. Therefore, a new `QuantizedParamsType=Conv1D` is used to differentiate the two, and has to extract 1D information from 2D packed parameters. [ghstack-poisoned]
|
@BowenBao PTAL |
|
@pytorchbot rebase |
|
@pytorchbot successfully started a rebase job. Check the current status here |
According to #38248, quantized::conv1d_relu shares packing parameters with Conv2D (kspatialDim is also 2), and needs a different unpacking way. Therefore, a new `QuantizedParamsType=Conv1D` is used to differentiate the two, and has to extract 1D information from 2D packed parameters. [ghstack-poisoned]
|
Successfully rebased |
|
@pytorchbot merge -g |
Merge startedYour change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Hey @AllenTiTaiWang. |
According to pytorch#38248, quantized::conv1d_relu shares packing parameters with Conv2D (kspatialDim is also 2), and needs a different unpacking way. Therefore, a new `QuantizedParamsType=Conv1D` is used to differentiate the two, and has to extract 1D information from 2D packed parameters. Pull Request resolved: pytorch#85997 Approved by: https://github.com/BowenBao
According to pytorch#38248, quantized::conv1d_relu shares packing parameters with Conv2D (kspatialDim is also 2), and needs a different unpacking way. Therefore, a new `QuantizedParamsType=Conv1D` is used to differentiate the two, and has to extract 1D information from 2D packed parameters. Pull Request resolved: pytorch#85997 Approved by: https://github.com/BowenBao
According to pytorch#38248, quantized::conv1d_relu shares packing parameters with Conv2D (kspatialDim is also 2), and needs a different unpacking way. Therefore, a new `QuantizedParamsType=Conv1D` is used to differentiate the two, and has to extract 1D information from 2D packed parameters. Pull Request resolved: pytorch#85997 Approved by: https://github.com/BowenBao
Stack from ghstack (oldest at bottom):
According to #38248, quantized::conv1d_relu shares packing parameters with Conv2D (kspatialDim is also 2), and needs a different unpacking way. Therefore, a new
QuantizedParamsType=Conv1Dis used to differentiate the two, and has to extract 1D information from 2D packed parameters.Fix #84694