Delete torch::deploy from pytorch core#85901
Closed
PaliC wants to merge 5 commits into
Closed
Conversation
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. Differential Revision: [D39933787](https://our.internmc.facebook.com/intern/diff/D39933787/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39933787/)! [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85901
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Failures, 2 PendingAs of commit f24df76: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. Differential Revision: [D39933787](https://our.internmc.facebook.com/intern/diff/D39933787/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39933787/)! [ghstack-poisoned]
d4l3k
reviewed
Sep 29, 2022
| // the dlMTensor has been consumed | ||
| // PyCapsule_GetPointer has set an error indicator | ||
| PyErr_Clear(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
fixed was a rebasing issue
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. Differential Revision: [D39933787](https://our.internmc.facebook.com/intern/diff/D39933787/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39933787/)! [ghstack-poisoned]
PaliC
added a commit
that referenced
this pull request
Sep 29, 2022
Pull Request resolved: #85901 As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. ghstack-source-id: 168867021 Differential Revision: [D39933787](https://our.internmc.facebook.com/intern/diff/D39933787/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39933787/)!
anirbanr-fb-r2p
approved these changes
Sep 29, 2022
malfet
approved these changes
Sep 29, 2022
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. Differential Revision: [D39933787](https://our.internmc.facebook.com/intern/diff/D39933787/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39933787/)! [ghstack-poisoned]
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. Differential Revision: [D39933787](https://our.internmc.facebook.com/intern/diff/D39933787/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39933787/)! [ghstack-poisoned]
PaliC
added a commit
that referenced
this pull request
Sep 29, 2022
Pull Request resolved: #85901 As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. ghstack-source-id: 168867021 Differential Revision: [D39933787](https://our.internmc.facebook.com/intern/diff/D39933787/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39933787/)!
Contributor
|
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there.
This PR was created due to syncing issues with #85443 which is where the review history can be found.
Differential Revision: D39933787
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!
cc @ezyang @SherlockNoMad @soumith @EikanWang @jgong5 @wenzhe-nrv