Skip to content

[DataPipe] Fix MapDataPipe spawn lambda test#85668

Closed
NivekT wants to merge 4 commits intogh/nivekt/55/basefrom
gh/nivekt/55/head
Closed

[DataPipe] Fix MapDataPipe spawn lambda test#85668
NivekT wants to merge 4 commits intogh/nivekt/55/basefrom
gh/nivekt/55/head

Conversation

@NivekT
Copy link
Contributor

@NivekT NivekT commented Sep 26, 2022 •
edited
Loading

Stack from ghstack:

The test in its original form fails and I believe it is because the expected result is incorrect, unless we expect different behaviors between IterDataPipe and MapDataPipe in multiprocessing.

Differential Revision: D39832182

@NivekT NivekT mentioned this pull request Sep 26, 2022
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85668

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1e65996:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 26, 2022
@NivekT NivekT added the release notes: dataloader release notes category label Sep 26, 2022
NivekT added a commit that referenced this pull request Sep 26, 2022
@NivekT
[DataPipe] Fix MapDataPipe spawn lambda test
c4f9142 
ghstack-source-id: f706c95
Pull Request resolved: #85668
@NivekT
Copy link
Contributor Author

NivekT commented Sep 26, 2022

@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

ejguan
ejguan approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NivekT
Update on "[DataPipe] Fix MapDataPipe spawn lambda test"
5523d81 
The test in its original form fails and I believe it is because the expected result is incorrect, unless we expect different behaviors between `IterDataPipe` and `MapDataPipe` in multiprocessing.

Differential Revision: [D39832182](https://our.internmc.facebook.com/intern/diff/D39832182)

[ghstack-poisoned]
NivekT added a commit that referenced this pull request Sep 27, 2022
@NivekT
[DataPipe] Fix MapDataPipe spawn lambda test
da69b83 
ghstack-source-id: 55661f5
Pull Request resolved: #85668
@NivekT
Copy link
Contributor Author

NivekT commented Sep 27, 2022

@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@NivekT
Update on "[DataPipe] Fix MapDataPipe spawn lambda test"
1e65996 
The test in its original form fails and I believe it is because the expected result is incorrect, unless we expect different behaviors between `IterDataPipe` and `MapDataPipe` in multiprocessing.

Differential Revision: [D39832182](https://our.internmc.facebook.com/intern/diff/D39832182)

[ghstack-poisoned]
NivekT added a commit that referenced this pull request Sep 27, 2022
@NivekT
[DataPipe] Fix MapDataPipe spawn lambda test
3d9d7c7 
ghstack-source-id: f082a26
Pull Request resolved: #85668
@NivekT
Copy link
Contributor Author

NivekT commented Sep 27, 2022

@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@NivekT
Copy link
Contributor Author

NivekT commented Sep 27, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 27, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

drisspg pushed a commit to drisspg/pytorch that referenced this pull request Sep 29, 2022
@NivekT @drisspg
[DataPipe] Fix MapDataPipe spawn lambda test (pytorch#85668)
ef96edd 
The test in its original form fails and I believe it is because the expected result is incorrect, unless we expect different behaviors between `IterDataPipe` and `MapDataPipe` in multiprocessing.

Differential Revision: [D39832182](https://our.internmc.facebook.com/intern/diff/D39832182)
Pull Request resolved: pytorch#85668
Approved by: https://github.com/ejguan
@facebook-github-bot facebook-github-bot deleted the gh/nivekt/55/head branch October 1, 2022 14:19
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@NivekT @mehtanirav
[DataPipe] Fix MapDataPipe spawn lambda test (#85668)
66cd25f 
The test in its original form fails and I believe it is because the expected result is incorrect, unless we expect different behaviors between `IterDataPipe` and `MapDataPipe` in multiprocessing.

Differential Revision: [D39832182](https://our.internmc.facebook.com/intern/diff/D39832182)
Pull Request resolved: #85668
Approved by: https://github.com/ejguan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ejguan ejguan ejguan approved these changes

@VitalyFedyunin VitalyFedyunin Awaiting requested review from VitalyFedyunin

Assignees

No one assigned

Labels

cla signed Merged release notes: dataloader release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NivekT @pytorchmergebot @ejguan @facebook-github-bot