Add mkldnn fallbacks for Resnet50 training ops by wuhuikx · Pull Request #8541 · pytorch/pytorch

wuhuikx · 2018-06-15T01:09:01Z

Add fallback gradient ops
In fallback ops, set the output Tensor as CPUTensor instead of IDEEPTensor if ndim = 0. Because IDEEPTensor doesn't support 0 dim.

wuhuikx · 2018-06-15T02:18:03Z

@yinghai , could you pls help to review code?

yinghai · 2018-06-29T16:44:04Z

Rebase?

wuhuikx · 2018-07-02T06:15:12Z

Yes, have rebased.

facebook-github-bot

@yinghai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

caffe2/ideep/operators/operator_fallback_ideep.h

+      if (src.ndim() == 0) {
+        VLOG(1) << "Copy output: index " << i << " skipped.";
+        Blob* dst = OperatorBase::OutputBlob(i);
+        dst->Reset(new Tensor<CPUContext>());


jgong5 · 2018-07-13T03:58:08Z

@wesolwsk

jgong5 · 2018-07-27T00:35:42Z

@yinghai Any comments on the updates? OK to merge?

facebook-github-bot

yinghai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

yinghai · 2018-07-31T21:22:48Z

@jgong5 Could you rebase? There seems to be merge conflict.

wuhuikx · 2018-08-01T01:14:21Z

@yinghai I have rebased it yesterday and there is not conflict now.
However the rebased code cannot build successfully. The failure seems nothing to do with me.

facebook-github-bot

yinghai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

yinghai · 2018-08-01T04:39:03Z

@wuhuikx Could you double check??

facebook-github-bot

yinghai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

yinghai

You need to do

git checkout master
git fetch upstream
git merge upstream/master

to really sync up the code.

caffe2/ideep/operators/operator_fallback_ideep.h

+      if (src.ndim() == 0) {
+        VLOG(1) << "Copy output: index " << i << " skipped.";
+        Blob* dst = OperatorBase::OutputBlob(i);
+        dst->Reset(new Tensor<CPUContext>());


…snet50

facebook-github-bot

yinghai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

yinghai

LG

caffe2/ideep/operators/operator_fallback_ideep.h

+      if (src.ndim() == 0) {
+        VLOG(1) << "Copy output: index " << i << " skipped.";
+        Blob* dst = OperatorBase::OutputBlob(i);
+        dst->Reset(new Tensor<CPU>());


wuhuikx · 2018-08-02T06:40:02Z

@yinghai Have revised and pass all checks. Pls help review.

facebook-github-bot

yinghai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

caffe2/ideep/operators/operator_fallback_ideep.h

+        VLOG(1) << "Copy output: index " << i << " skipped.";
+        Blob* dst = OperatorBase::OutputBlob(i);
+        dst->Reset(new Tensor(CPU));
+        auto dtensor = dst->template GetMutable<TensorCPU>();


wuhuikx · 2018-08-03T03:27:28Z

@yinghai Revised Done. Sorry for inconvenient.

wesolwsk · 2018-08-03T03:28:00Z

What is the process for check-in? Import to phabricator and accept from there?

facebook-github-bot

wesolwsk has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

caffe2/ideep/operators/operator_fallback_ideep.h

          "output type who needs copying.");
      const auto& src = local_output_blobs_[i]->template Get<TensorCPU>();

+      auto src_dims = src.dims();


facebook-github-bot

wesolwsk has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: 1. Add fallback gradient ops 2. In fallback ops, set the output Tensor as CPUTensor instead of IDEEPTensor if ndim = 0. Because IDEEPTensor doesn't support 0 dim. Pull Request resolved: pytorch#8541 Reviewed By: yinghai Differential Revision: D9115233 Pulled By: wesolwsk fbshipit-source-id: 163e6a76f02bd781c95d1060ccbacf2cab90055e

[IDEEP] Add IDEEP fallbacks for Resnet50 training ops

275afb0

onnxbot added the caffe2 label Jun 15, 2018

Merge remote-tracking branch 'pytorch/master' into resnet50

6482ff4

facebook-github-bot reviewed Jul 2, 2018

View reviewed changes

yinghai reviewed Jul 2, 2018

View reviewed changes

Merge branch 'master' into resnet50

60eff92

facebook-github-bot reviewed Jul 31, 2018

View reviewed changes

facebook-github-bot reviewed Aug 1, 2018

View reviewed changes

Merge remote-tracking branch 'pytorch/master' into resnet50

85ef04c

facebook-github-bot reviewed Aug 1, 2018

View reviewed changes

yinghai suggested changes Aug 1, 2018

View reviewed changes

caffe2/ideep/operators/operator_fallback_ideep.h Outdated

if (src.ndim() == 0) {

VLOG(1) << "Copy output: index " << i << " skipped.";

Blob* dst = OperatorBase::OutputBlob(i);

dst->Reset(new Tensor<CPUContext>());

This comment was marked as off-topic.

Sign in to view

wuhuikx and others added 4 commits August 2, 2018 08:34

Merge remote-tracking branch 'pytorch/master' into resnet50

ee8e03e

Merge remote-tracking branch 'pytorch/master' into resnet50

cf19c54

Update operator_fallback_ideep.h

d6eb5b9

Merge branch 'resnet50' of https://github.com/wuhuikx/pytorch into re…

08dede2

…snet50

facebook-github-bot reviewed Aug 2, 2018

View reviewed changes

yinghai approved these changes Aug 2, 2018

View reviewed changes

yinghai suggested changes Aug 2, 2018

View reviewed changes

caffe2/ideep/operators/operator_fallback_ideep.h Outdated

if (src.ndim() == 0) {

VLOG(1) << "Copy output: index " << i << " skipped.";

Blob* dst = OperatorBase::OutputBlob(i);

dst->Reset(new Tensor<CPU>());

This comment was marked as off-topic.

Sign in to view

wuhuikx added 2 commits August 2, 2018 13:08

Update operator_fallback_ideep.h

e5429ed

Update operator_fallback_ideep.h

b1c60f6

facebook-github-bot reviewed Aug 2, 2018

View reviewed changes

wesolwsk reviewed Aug 2, 2018

View reviewed changes

caffe2/ideep/operators/operator_fallback_ideep.h Outdated

VLOG(1) << "Copy output: index " << i << " skipped.";

Blob* dst = OperatorBase::OutputBlob(i);

dst->Reset(new Tensor(CPU));

auto dtensor = dst->template GetMutable<TensorCPU>();

This comment was marked as off-topic.

Sign in to view

wuhuikx added 2 commits August 3, 2018 08:22

Update operator_fallback_ideep.h

f0525b4

Update operator_fallback_ideep.h

e4e73b2

facebook-github-bot reviewed Aug 3, 2018

View reviewed changes

wesolwsk reviewed Aug 3, 2018

View reviewed changes

caffe2/ideep/operators/operator_fallback_ideep.h

"output type who needs copying.");

const auto& src = local_output_blobs_[i]->template Get<TensorCPU>();

auto src_dims = src.dims();

This comment was marked as off-topic.

Sign in to view

Update operator_fallback_ideep.h

f9660c2

facebook-github-bot reviewed Aug 3, 2018

View reviewed changes

facebook-github-bot closed this in c5abe88 Aug 3, 2018

wuhuikx changed the title ~~[IDEEP] Add IDEEP fallbacks for Resnet50 training ops~~ Add mkldnn fallbacks for Resnet50 training ops Aug 7, 2018

ezyang added open source merged labels Jun 24, 2019

Conversation

wuhuikx commented Jun 15, 2018

Uh oh!

wuhuikx commented Jun 15, 2018

Uh oh!

yinghai commented Jun 29, 2018

Uh oh!

wuhuikx commented Jul 2, 2018

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

jgong5 commented Jul 13, 2018

Uh oh!

jgong5 commented Jul 27, 2018

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

yinghai commented Jul 31, 2018

Uh oh!

wuhuikx commented Aug 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

yinghai commented Aug 1, 2018

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

yinghai left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as off-topic.

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

yinghai left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as off-topic.

Uh oh!

wuhuikx commented Aug 2, 2018

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as off-topic.

Uh oh!

wuhuikx commented Aug 3, 2018

Uh oh!

wesolwsk commented Aug 3, 2018

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as off-topic.

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

wuhuikx commented Aug 1, 2018 •

edited

Loading