Skip to content

[QNNPACK] Export cpuinfo-targets in clog CMakeLists#84876

Closed
salilsdesai wants to merge 1 commit intopytorch:masterfrom
salilsdesai:export-D39438768
Closed

[QNNPACK] Export cpuinfo-targets in clog CMakeLists#84876
salilsdesai wants to merge 1 commit intopytorch:masterfrom
salilsdesai:export-D39438768

Conversation

@salilsdesai
Copy link
Copy Markdown
Contributor

@salilsdesai salilsdesai commented Sep 12, 2022

Summary:
Fixes the following error when building qnnpack:

CMake Error: install(EXPORT "cpuinfo-targets" ...) includes target "cpuinfo" which requires target "clog" that is not in any export set.

This diff mirrors the changes to the CMakeLists of
pytorch/cpuinfo#69

Test Plan:

Build Qnnpack

export ANDROID_NDK=/opt/android_ndk/r20
export ANDROID_NDK_HOME=${ANDROID_NDK}
export ANDROID_SDK=/opt/android_sdk
export ANDROID_HOME=${ANDROID_SDK}

cd ~/fbsource/fbcode/caffe2/aten/src/ATen/native/quantized/cpu/qnnpack

./scripts/build-android-arm64.sh

Succeeds

Differential Revision: D39438768

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Sep 12, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84876

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3740c35:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 12, 2022
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 12, 2022

This pull request was exported from Phabricator. Differential Revision: D39438768

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 12, 2022

This pull request was exported from Phabricator. Differential Revision: D39438768

@salilsdesai @facebook-github-bot
[QNNPACK] Export cpuinfo-targets in clog CMakeLists (pytorch#84876)
3740c35 
Summary:
Pull Request resolved: pytorch#84876

Fixes the following error when building qnnpack:
```
CMake Error: install(EXPORT "cpuinfo-targets" ...) includes target "cpuinfo" which requires target "clog" that is not in any export set.
```

This diff mirrors the changes to the CMakeLists of
- pytorch/cpuinfo#69
- pytorch/cpuinfo#89

Test Plan:
# Build Qnnpack
```
export ANDROID_NDK=/opt/android_ndk/r20
export ANDROID_NDK_HOME=${ANDROID_NDK}
export ANDROID_SDK=/opt/android_sdk
export ANDROID_HOME=${ANDROID_SDK}

cd ~/fbsource/fbcode/caffe2/aten/src/ATen/native/quantized/cpu/qnnpack

./scripts/build-android-arm64.sh
```
Succeeds

Differential Revision: D39438768

fbshipit-source-id: 9bd0119ffea984d274e85b8b756b630743a89f0f
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 16, 2022

This pull request was exported from Phabricator. Differential Revision: D39438768

digantdesai
digantdesai approved these changes Sep 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @salilsdesai

@salilsdesai
Copy link
Copy Markdown
Contributor Author

salilsdesai commented Sep 16, 2022

@pytorchmergebot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 16, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@salilsdesai @mehtanirav
[QNNPACK] Export cpuinfo-targets in clog CMakeLists (#84876)
b14c2ec 
Summary:
Fixes the following error when building qnnpack:
```
CMake Error: install(EXPORT "cpuinfo-targets" ...) includes target "cpuinfo" which requires target "clog" that is not in any export set.
```

This diff mirrors the changes to the CMakeLists of
pytorch/cpuinfo#69

Test Plan:
# Build Qnnpack
```
export ANDROID_NDK=/opt/android_ndk/r20
export ANDROID_NDK_HOME=${ANDROID_NDK}
export ANDROID_SDK=/opt/android_sdk
export ANDROID_HOME=${ANDROID_SDK}

cd ~/fbsource/fbcode/caffe2/aten/src/ATen/native/quantized/cpu/qnnpack

./scripts/build-android-arm64.sh
```
Succeeds

Differential Revision: D39438768

Pull Request resolved: #84876
Approved by: https://github.com/digantdesai
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes

@vkuzo vkuzo Awaiting requested review from vkuzo

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168

@z-a-f z-a-f Awaiting requested review from z-a-f

@kimishpatel kimishpatel Awaiting requested review from kimishpatel

@jianyuh jianyuh Awaiting requested review from jianyuh

Assignees

No one assigned

Labels

cla signed fb-exported Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@salilsdesai @facebook-github-bot @pytorchmergebot @digantdesai