Skip to content

[C++ API] Added missing antialiasing path in interpolation C++ api#84599

Closed
vfdev-5 wants to merge 1 commit intopytorch:masterfrom
vfdev-5:update-interp-aa-bicubic-cppapi
Closed

[C++ API] Added missing antialiasing path in interpolation C++ api#84599
vfdev-5 wants to merge 1 commit intopytorch:masterfrom
vfdev-5:update-interp-aa-bicubic-cppapi

Conversation

@vfdev-5
Copy link
Copy Markdown
Contributor

@vfdev-5 vfdev-5 commented Sep 6, 2022

Description:

Following #69318 (comment) adding missing bicubic path for anti-alias flag to C++ frontend.

@pytorch-bot pytorch-bot bot added the release notes: cpp release notes category label Sep 6, 2022
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 6, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit fddd25a (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@vfdev-5 vfdev-5 force-pushed the update-interp-aa-bicubic-cppapi branch from 7682159 to fddd25a Compare September 6, 2022 21:47
@vfdev-5 vfdev-5 requested a review from jbschlosser September 7, 2022 08:36
@malfet
Copy link
Copy Markdown
Contributor

malfet commented Sep 13, 2022

@pytorchbot merge -g

@malfet malfet added the topic: bug fixes topic category label Sep 13, 2022
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 13, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 13, 2022

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again.

Details for Dev Infra team Raised by workflow job

@malfet
Copy link
Copy Markdown
Contributor

malfet commented Sep 13, 2022

@pytorchbot merge -f "This codepath is not frequently changed"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 13, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@mehtanirav
[C++ API] Added missing antialiasing path in interpolation C++ api (#…
1258e6f 
…84599)

Description:

Following #69318 (comment) adding missing bicubic path for anti-alias flag to C++ frontend.

- #70930

- added tests in pytorch/test/cpp/api/functional.cpp

Pull Request resolved: #84599
Approved by: https://github.com/kit1980, https://github.com/malfet
@vfdev-5 vfdev-5 deleted the update-interp-aa-bicubic-cppapi branch May 25, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

+1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged open source release notes: cpp release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vfdev-5 @facebook-github-bot @malfet @pytorchmergebot @kit1980 @pytorchbot