[GHF] Changing the ordering in merge rules to allow more appropriate messages to be raised first by NivekT · Pull Request #84359 · pytorch/pytorch

NivekT · 2022-08-31T16:04:35Z

Stack from ghstack (oldest at bottom):

-> [GHF] Changing the ordering in merge rules to allow more appropriate messages to be raised first #84359

Changing the ordering in merge rules to allow more appropriate messages to be raised first.

Context: #84279
@janeyx99: "Approving to unblock, but modifying the merge rules to move the Core maintainers rule to last would be a good idea."

…messages to be raised first [ghstack-poisoned]

facebook-github-bot · 2022-08-31T16:04:42Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84359
✖️ Python docs build was skipped
✖️ C++ docs build was skipped
❓Need help or want to give feedback on the CI? Visit our office hours
↩️ [fb-only] Re-run with SSH instructions

❌ 1 New Failures

As of commit 94c2ce3 (more details on the Dr. CI page):

Expand to see more

1/1 failures introduced in this PR

🕵️‍♀️ 1 failure not recognized by patterns:

The following CI failures may be due to changes from the PR

Job	Step
^build	^Unknown

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

NivekT · 2022-08-31T16:05:55Z

@pytorchbot rebase

pytorchmergebot · 2022-08-31T16:07:31Z

@pytorchbot successfully started a rebase job. Check the current status here

…ppropriate messages to be raised first" Changing the ordering in merge rules to allow more appropriate messages to be raised first. Context: [#84279](#84279 (comment)) janeyx99: "Approving to unblock, but modifying the merge rules to move the Core maintainers rule to last would be a good idea." [ghstack-poisoned]

pytorchmergebot · 2022-08-31T16:07:44Z

Successfully rebased gh/nivekt/56/orig onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/84359)

NivekT · 2022-08-31T17:23:20Z

@pytorchbot rebase

pytorchmergebot · 2022-08-31T17:25:30Z

@pytorchbot successfully started a rebase job. Check the current status here

…ppropriate messages to be raised first" Changing the ordering in merge rules to allow more appropriate messages to be raised first. Context: [#84279](#84279 (comment)) janeyx99: "Approving to unblock, but modifying the merge rules to move the Core maintainers rule to last would be a good idea." [ghstack-poisoned]

pytorchmergebot · 2022-08-31T17:25:44Z

Successfully rebased gh/nivekt/56/orig onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/84359)

janeyx99

woo

NivekT · 2022-08-31T18:25:24Z

@pytorchbot rebase -s

pytorchmergebot · 2022-08-31T18:27:12Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2022-08-31T18:27:22Z

Tried to rebase and push PR #84359, but it was already up to date

ZainRizvi

🚀🚀🚀

NivekT · 2022-08-31T19:39:40Z

@pytorchbot rebase

pytorchmergebot · 2022-08-31T19:41:33Z

@pytorchbot successfully started a rebase job. Check the current status here

…ppropriate messages to be raised first" Changing the ordering in merge rules to allow more appropriate messages to be raised first. Context: [#84279](#84279 (comment)) janeyx99: "Approving to unblock, but modifying the merge rules to move the Core maintainers rule to last would be a good idea." [ghstack-poisoned]

pytorchmergebot · 2022-08-31T19:41:47Z

Successfully rebased gh/nivekt/56/orig onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/84359)

…messages to be raised first ghstack-source-id: 27c1a34 Pull Request resolved: #84359

NivekT · 2022-09-01T15:10:26Z

@pytorchbot rebase -s

pytorchmergebot · 2022-09-01T15:12:29Z

@pytorchbot successfully started a rebase job. Check the current status here

…ppropriate messages to be raised first" Changing the ordering in merge rules to allow more appropriate messages to be raised first. Context: [#84279](#84279 (comment)) janeyx99: "Approving to unblock, but modifying the merge rules to move the Core maintainers rule to last would be a good idea." [ghstack-poisoned]

pytorchmergebot · 2022-09-01T15:12:44Z

Successfully rebased gh/nivekt/56/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/84359)

…messages to be raised first ghstack-source-id: d9f769f Pull Request resolved: #84359

NivekT · 2022-09-01T15:31:14Z

@pytorchbot merge

pytorchmergebot · 2022-09-01T15:32:38Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

malfet · 2022-09-01T16:53:53Z

@pytorchbot merge -f "Lintrunner is sufficient for those"

pytorchmergebot · 2022-09-01T16:54:10Z

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

pytorchmergebot · 2022-09-01T16:56:48Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

github-actions · 2022-09-01T16:57:38Z

Hey @NivekT.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

…messages to be raised first (#84359) (#84359) Summary: Changing the ordering in merge rules to allow more appropriate messages to be raised first. Context: [#84279](#84279 (comment)) janeyx99: "Approving to unblock, but modifying the merge rules to move the Core maintainers rule to last would be a good idea." Pull Request resolved: #84359 Approved by: https://github.com/janeyx99, https://github.com/ZainRizvi, https://github.com/malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d648375f13b4a4efd4cd35247098679fce5d4bcd Reviewed By: mehtanirav Differential Revision: D39214439 Pulled By: NivekT fbshipit-source-id: 0fbff5b4aacb9365bdced9d7bbe28bd7c7815a55

[GHF] Changing the ordering in merge rules to allow more appropriate …

e7d55b6

…messages to be raised first [ghstack-poisoned]

NivekT requested a review from a team as a code owner August 31, 2022 16:04

pytorch-bot bot added the release notes: releng release notes category label Aug 31, 2022

facebook-github-bot added the cla signed label Aug 31, 2022

janeyx99 approved these changes Aug 31, 2022

View reviewed changes

ZainRizvi approved these changes Aug 31, 2022

View reviewed changes

pytorchmergebot pushed a commit that referenced this pull request Aug 31, 2022

[GHF] Changing the ordering in merge rules to allow more appropriate …

ffed05b

…messages to be raised first ghstack-source-id: 27c1a34 Pull Request resolved: #84359

pytorchmergebot pushed a commit that referenced this pull request Sep 1, 2022

[GHF] Changing the ordering in merge rules to allow more appropriate …

4d4c025

…messages to be raised first ghstack-source-id: d9f769f Pull Request resolved: #84359

malfet approved these changes Sep 1, 2022

View reviewed changes

pytorchmergebot added the Merged label Sep 1, 2022

pytorchmergebot closed this in d648375 Sep 1, 2022

malfet added the topic: not user facing topic category label Sep 1, 2022

facebook-github-bot deleted the gh/nivekt/56/head branch September 5, 2022 14:20

Conversation

NivekT commented Aug 31, 2022 • edited by pytorchmergebot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Aug 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

❌ 1 New Failures

🕵️‍♀️ 1 failure not recognized by patterns:

Uh oh!

NivekT commented Aug 31, 2022

Uh oh!

pytorchmergebot commented Aug 31, 2022

Uh oh!

pytorchmergebot commented Aug 31, 2022

Uh oh!

NivekT commented Aug 31, 2022

Uh oh!

pytorchmergebot commented Aug 31, 2022

Uh oh!

pytorchmergebot commented Aug 31, 2022

Uh oh!

janeyx99 left a comment

Choose a reason for hiding this comment

Uh oh!

NivekT commented Aug 31, 2022

Uh oh!

pytorchmergebot commented Aug 31, 2022

Uh oh!

pytorchmergebot commented Aug 31, 2022

Uh oh!

ZainRizvi left a comment

Choose a reason for hiding this comment

Uh oh!

NivekT commented Aug 31, 2022

Uh oh!

pytorchmergebot commented Aug 31, 2022

Uh oh!

pytorchmergebot commented Aug 31, 2022

Uh oh!

NivekT commented Sep 1, 2022

Uh oh!

pytorchmergebot commented Sep 1, 2022

Uh oh!

pytorchmergebot commented Sep 1, 2022

Uh oh!

NivekT commented Sep 1, 2022

Uh oh!

pytorchmergebot commented Sep 1, 2022

Uh oh!

malfet commented Sep 1, 2022

Uh oh!

pytorchmergebot commented Sep 1, 2022

Uh oh!

pytorchmergebot commented Sep 1, 2022

Uh oh!

github-actions bot commented Sep 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

NivekT commented Aug 31, 2022 •

edited by pytorchmergebot

Loading

facebook-github-bot commented Aug 31, 2022 •

edited

Loading