Skip to content

[ROCm] guard ROCm-only files in NVFUSER_RUNTIME_FILES#84312

Closed
jeffdaily wants to merge 2 commits intopytorch:masterfrom
ROCm:rocm_nvfuser_build_nit
Closed

[ROCm] guard ROCm-only files in NVFUSER_RUNTIME_FILES#84312
jeffdaily wants to merge 2 commits intopytorch:masterfrom
ROCm:rocm_nvfuser_build_nit

Conversation

@jeffdaily
Copy link
Collaborator

@jeffdaily jeffdaily commented Aug 30, 2022

Addresses comment in #82498 as a follow-up PR.

#82498 (comment)

@jeffdaily jeffdaily requested a review from jjsjann123 August 30, 2022 22:30
@pytorch-bot pytorch-bot bot added module: rocm AMD GPU support for Pytorch release notes: jit release notes category labels Aug 30, 2022
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 30, 2022 •
edited
Loading

🔗 Helpful links

❌ 1 New Failures, 1 Pending

As of commit 21a553b (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️‍♀️ 1 failure not recognized by patterns:

The following CI failures may be due to changes from the PR
Job Step
CircleCI Checks build Unknown
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 30, 2022
@jeffdaily
Copy link
Collaborator Author

jeffdaily commented Aug 30, 2022

@jjsjann123 let's wait for green CI signal before landing.

@jeffdaily jeffdaily mentioned this pull request Aug 30, 2022
Closed
jjsjann123
jjsjann123 approved these changes Aug 31, 2022
View reviewed changes
Copy link
Collaborator

@jjsjann123 jjsjann123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffdaily
Copy link
Collaborator Author

jeffdaily commented Aug 31, 2022

@pytorchbot merge -f "CI is green except for unauthorized ios builds"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 31, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2022

Hey @jeffdaily.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@jithunnair-amd jithunnair-amd deleted the rocm_nvfuser_build_nit branch September 1, 2022 19:26
facebook-github-bot pushed a commit that referenced this pull request Sep 2, 2022
@jeffdaily @facebook-github-bot
[ROCm] guard ROCm-only files in NVFUSER_RUNTIME_FILES (#84312) (#84312)
8b4eef6 
Summary:
Addresses comment in #82498 as a follow-up PR.

#82498 (comment)

Pull Request resolved: #84312
Approved by: https://github.com/jjsjann123

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/6efadf7e7e6655b543b5a9819b6e2eac2d76f09c

Reviewed By: mehtanirav

Differential Revision: D39213490

fbshipit-source-id: c6158d4880c0614289c23f5af4823773a9545dd1
jjsjann123 pushed a commit to jjsjann123/nvfuser that referenced this pull request Oct 29, 2022
@jeffdaily @pytorchmergebot
[ROCm] guard ROCm-only files in NVFUSER_RUNTIME_FILES (#84312)
de009e3 
Addresses comment in #82498 as a follow-up PR.

pytorch/pytorch#82498 (comment)
Pull Request resolved: pytorch/pytorch#84312
Approved by: https://github.com/jjsjann123
jjsjann123 pushed a commit to jjsjann123/nvfuser that referenced this pull request Nov 10, 2022
@jeffdaily @pytorchmergebot
[ROCm] guard ROCm-only files in NVFUSER_RUNTIME_FILES (#84312)
419399b 
Addresses comment in #82498 as a follow-up PR.

pytorch/pytorch#82498 (comment)
Pull Request resolved: pytorch/pytorch#84312
Approved by: https://github.com/jjsjann123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjsjann123 jjsjann123 jjsjann123 approved these changes

Assignees

No one assigned

Labels

cla signed Merged module: rocm AMD GPU support for Pytorch oncall: jit Add this issue/PR to JIT oncall triage queue open source release notes: jit release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jeffdaily @facebook-github-bot @pytorchmergebot @jjsjann123 @pytorchbot