Skip to content

remove BC-guarantee for reinplace pass#83265

Closed
bdhirsh wants to merge 7 commits intogh/bdhirsh/296/basefrom
gh/bdhirsh/296/head
Closed

remove BC-guarantee for reinplace pass#83265
bdhirsh wants to merge 7 commits intogh/bdhirsh/296/basefrom
gh/bdhirsh/296/head

Conversation

@bdhirsh
Copy link
Collaborator

@bdhirsh bdhirsh commented Aug 11, 2022 •
edited by pytorch-bot bot
Loading

@bdhirsh bdhirsh mentioned this pull request Aug 11, 2022
Closed
This was referenced Aug 11, 2022
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 11, 2022 •
edited
Loading

🔗 Helpful links

❌ 7 New Failures

As of commit 3c3ce0a (more details on the Dr. CI page):

Expand to see more
  • 7/7 failures introduced in this PR

🕵️ 7 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-bionic-py3.7-clang9 / test (dynamo, 1, 2, linux.2xlarge) (1/7)

Step: "Test" (full log | diagnosis details)

2022-08-11T18:24:28.8403322Z FAIL [0.036s]: tes..._surface (__main__.TestFXAPIBackwardCompatibility) 
2022-08-11T18:24:23.3928388Z   test_type_check_reshape_false (fx.test_gradual_type.TypeCheckerTest) ... ok (0.006s)
2022-08-11T18:24:23.3999546Z   test_type_check_reshape_true (fx.test_gradual_type.TypeCheckerTest) ... ok (0.007s)
2022-08-11T18:24:23.4244964Z   test_type_check_symbolic_inferenceconv2D_maxpool2d_flatten (fx.test_gradual_type.TypeCheckerTest) ... ok (0.024s)
2022-08-11T18:24:23.4326609Z   test_type_check_transpose_False (fx.test_gradual_type.TypeCheckerTest) ... ok (0.008s)
2022-08-11T18:24:23.4403139Z   test_type_check_transpose_true (fx.test_gradual_type.TypeCheckerTest) ... ok (0.008s)
2022-08-11T18:24:28.7682542Z   test_type_maxpool2d_fully_static (fx.test_gradual_type.TypeCheckerTest) ... ok (5.328s)
2022-08-11T18:24:28.7783276Z   test_type_typechecl_maxpool2d_3dinput (fx.test_gradual_type.TypeCheckerTest) ... ok (0.010s)
2022-08-11T18:24:28.8401418Z   test_typecheck_basicblock (fx.test_gradual_type.TypeCheckerTest) ... ok (0.062s)
2022-08-11T18:24:28.8402636Z 
2022-08-11T18:24:28.8402915Z ======================================================================
2022-08-11T18:24:28.8403322Z FAIL [0.036s]: test_public_api_surface (__main__.TestFXAPIBackwardCompatibility)
2022-08-11T18:24:28.8405279Z ----------------------------------------------------------------------
2022-08-11T18:24:28.8405862Z Traceback (most recent call last):
2022-08-11T18:24:28.8406274Z   File "test_fx.py", line 3782, in test_public_api_surface
2022-08-11T18:24:28.8406629Z     def test_public_api_surface(self):
2022-08-11T18:24:28.8407021Z   File "test_fx.py", line 3782, in test_public_api_surface
2022-08-11T18:24:28.8407435Z     def test_public_api_surface(self):
2022-08-11T18:24:28.8408194Z   File "test_fx.py", line 3782, in test_public_api_surface
2022-08-11T18:24:28.8408452Z     def test_public_api_surface(self):
2022-08-11T18:24:28.8408714Z   File "test_fx.py", line 3814, in test_public_api_surface
2022-08-11T18:24:28.8409040Z     raise AssertionError(f"Public FX API(s) {non_back_compat_strs} introduced but not given a "

See GitHub Actions build pull / win-vs2019-cpu-py3 / test (default, 1, 2, windows.4xlarge) (2/7)

Step: "Test" (full log | diagnosis details)

2022-08-11T17:29:06.7540851Z FAIL [0.000s]: tes..._surface (__main__.TestFXAPIBackwardCompatibility) 
2022-08-11T17:29:06.7001106Z   test_type_check_reshape_false (fx.test_gradual_type.TypeCheckerTest) ... ok (0.000s)
2022-08-11T17:29:06.7039213Z   test_type_check_reshape_true (fx.test_gradual_type.TypeCheckerTest) ... ok (0.010s)
2022-08-11T17:29:06.7061853Z   test_type_check_symbolic_inferenceconv2D_maxpool2d_flatten (fx.test_gradual_type.TypeCheckerTest) ... skip: no sympy (0.000s)
2022-08-11T17:29:06.7094171Z   test_type_check_transpose_False (fx.test_gradual_type.TypeCheckerTest) ... ok (0.000s)
2022-08-11T17:29:06.7131169Z   test_type_check_transpose_true (fx.test_gradual_type.TypeCheckerTest) ... ok (0.000s)
2022-08-11T17:29:06.7408549Z   test_type_maxpool2d_fully_static (fx.test_gradual_type.TypeCheckerTest) ... ok (0.031s)
2022-08-11T17:29:06.7453847Z   test_type_typechecl_maxpool2d_3dinput (fx.test_gradual_type.TypeCheckerTest) ... ok (0.010s)
2022-08-11T17:29:06.7539361Z   test_typecheck_basicblock (fx.test_gradual_type.TypeCheckerTest) ... ok (0.000s)
2022-08-11T17:29:06.7540068Z 
2022-08-11T17:29:06.7540231Z ======================================================================
2022-08-11T17:29:06.7540851Z FAIL [0.000s]: test_public_api_surface (__main__.TestFXAPIBackwardCompatibility)
2022-08-11T17:29:06.7541332Z ----------------------------------------------------------------------
2022-08-11T17:29:06.7541687Z Traceback (most recent call last):
2022-08-11T17:29:06.7542140Z   File "test_fx.py", line 3814, in test_public_api_surface
2022-08-11T17:29:06.7542672Z     raise AssertionError(f"Public FX API(s) {non_back_compat_strs} introduced but not given a "
2022-08-11T17:29:06.7543607Z AssertionError: Public FX API(s) ['torch.fx.passes.reinplace.reinplace'] introduced but not given a backwards-compatibility classification! Please decorate these API(s) with `@torch.fx._compatibility.compatibility` to specify BC guarantees.
2022-08-11T17:29:06.7544185Z 
2022-08-11T17:29:06.8825855Z ----------------------------------------------------------------------
2022-08-11T17:29:06.8826329Z Ran 1002 tests in 8.266s
2022-08-11T17:29:06.8826494Z 
2022-08-11T17:29:06.8826691Z FAILED (failures=1, skipped=208, expected failures=5)

See GitHub Actions build pull / linux-bionic-py3.7-clang9 / test (default, 1, 2, linux.2xlarge) (3/7)

Step: "Test" (full log | diagnosis details)

2022-08-11T16:05:38.7817861Z FAIL [0.002s]: tes..._surface (__main__.TestFXAPIBackwardCompatibility) 
2022-08-11T16:05:38.7191620Z   test_type_check_reshape_false (fx.test_gradual_type.TypeCheckerTest) ... ok (0.003s)
2022-08-11T16:05:38.7222696Z   test_type_check_reshape_true (fx.test_gradual_type.TypeCheckerTest) ... ok (0.003s)
2022-08-11T16:05:38.7388485Z   test_type_check_symbolic_inferenceconv2D_maxpool2d_flatten (fx.test_gradual_type.TypeCheckerTest) ... ok (0.016s)
2022-08-11T16:05:38.7417931Z   test_type_check_transpose_False (fx.test_gradual_type.TypeCheckerTest) ... ok (0.003s)
2022-08-11T16:05:38.7449954Z   test_type_check_transpose_true (fx.test_gradual_type.TypeCheckerTest) ... ok (0.003s)
2022-08-11T16:05:38.7699540Z   test_type_maxpool2d_fully_static (fx.test_gradual_type.TypeCheckerTest) ... ok (0.025s)
2022-08-11T16:05:38.7743495Z   test_type_typechecl_maxpool2d_3dinput (fx.test_gradual_type.TypeCheckerTest) ... ok (0.004s)
2022-08-11T16:05:38.7814504Z   test_typecheck_basicblock (fx.test_gradual_type.TypeCheckerTest) ... ok (0.007s)
2022-08-11T16:05:38.7815347Z 
2022-08-11T16:05:38.7817403Z ======================================================================
2022-08-11T16:05:38.7817861Z FAIL [0.002s]: test_public_api_surface (__main__.TestFXAPIBackwardCompatibility)
2022-08-11T16:05:38.7818381Z ----------------------------------------------------------------------
2022-08-11T16:05:38.7818795Z Traceback (most recent call last):
2022-08-11T16:05:38.7819235Z   File "test_fx.py", line 3814, in test_public_api_surface
2022-08-11T16:05:38.7820245Z     raise AssertionError(f"Public FX API(s) {non_back_compat_strs} introduced but not given a "
2022-08-11T16:05:38.7821495Z AssertionError: Public FX API(s) ['torch.fx.passes.reinplace.reinplace'] introduced but not given a backwards-compatibility classification! Please decorate these API(s) with `@torch.fx._compatibility.compatibility` to specify BC guarantees.
2022-08-11T16:05:38.7822257Z 
2022-08-11T16:05:38.7822541Z ----------------------------------------------------------------------
2022-08-11T16:05:38.7822789Z Ran 1100 tests in 194.697s
2022-08-11T16:05:38.7822892Z 
2022-08-11T16:05:38.7823019Z FAILED (failures=1, skipped=194, expected failures=5)

See GitHub Actions build pull / linux-focal-py3.7-gcc7 / test (default, 1, 2, linux.2xlarge) (4/7)

Step: "Test" (full log | diagnosis details)

2022-08-11T16:04:32.4306368Z FAIL [0.002s]: tes..._surface (__main__.TestFXAPIBackwardCompatibility) 
2022-08-11T16:04:32.3646012Z   test_type_check_reshape_false (fx.test_gradual_type.TypeCheckerTest) ... ok (0.003s)
2022-08-11T16:04:32.3676758Z   test_type_check_reshape_true (fx.test_gradual_type.TypeCheckerTest) ... ok (0.003s)
2022-08-11T16:04:32.3838149Z   test_type_check_symbolic_inferenceconv2D_maxpool2d_flatten (fx.test_gradual_type.TypeCheckerTest) ... ok (0.016s)
2022-08-11T16:04:32.3865591Z   test_type_check_transpose_False (fx.test_gradual_type.TypeCheckerTest) ... ok (0.003s)
2022-08-11T16:04:32.3897584Z   test_type_check_transpose_true (fx.test_gradual_type.TypeCheckerTest) ... ok (0.003s)
2022-08-11T16:04:32.4188267Z   test_type_maxpool2d_fully_static (fx.test_gradual_type.TypeCheckerTest) ... ok (0.029s)
2022-08-11T16:04:32.4233347Z   test_type_typechecl_maxpool2d_3dinput (fx.test_gradual_type.TypeCheckerTest) ... ok (0.005s)
2022-08-11T16:04:32.4305313Z   test_typecheck_basicblock (fx.test_gradual_type.TypeCheckerTest) ... ok (0.007s)
2022-08-11T16:04:32.4305703Z 
2022-08-11T16:04:32.4305882Z ======================================================================
2022-08-11T16:04:32.4306368Z FAIL [0.002s]: test_public_api_surface (__main__.TestFXAPIBackwardCompatibility)
2022-08-11T16:04:32.4308666Z ----------------------------------------------------------------------
2022-08-11T16:04:32.4308992Z Traceback (most recent call last):
2022-08-11T16:04:32.4309321Z   File "test_fx.py", line 3814, in test_public_api_surface
2022-08-11T16:04:32.4309722Z     raise AssertionError(f"Public FX API(s) {non_back_compat_strs} introduced but not given a "
2022-08-11T16:04:32.4310668Z AssertionError: Public FX API(s) ['torch.fx.passes.reinplace.reinplace'] introduced but not given a backwards-compatibility classification! Please decorate these API(s) with `@torch.fx._compatibility.compatibility` to specify BC guarantees.
2022-08-11T16:04:32.4311902Z 
2022-08-11T16:04:32.4312175Z ----------------------------------------------------------------------
2022-08-11T16:04:32.4312481Z Ran 1100 tests in 203.018s
2022-08-11T16:04:32.4312635Z 
2022-08-11T16:04:32.4312788Z FAILED (failures=1, skipped=194, expected failures=5)

See GitHub Actions build pull / linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 3, 4, linux.4xlarge.nvidia.gpu) (5/7)

Step: "Test" (full log | diagnosis details)

2022-08-11T16:20:17.8859267Z FAIL [0.003s]: tes..._surface (__main__.TestFXAPIBackwardCompatibility) 
2022-08-11T16:20:17.8150092Z   test_type_check_reshape_false (fx.test_gradual_type.TypeCheckerTest) ... ok (0.003s)
2022-08-11T16:20:17.8182759Z   test_type_check_reshape_true (fx.test_gradual_type.TypeCheckerTest) ... ok (0.003s)
2022-08-11T16:20:17.8366788Z   test_type_check_symbolic_inferenceconv2D_maxpool2d_flatten (fx.test_gradual_type.TypeCheckerTest) ... ok (0.018s)
2022-08-11T16:20:17.8399288Z   test_type_check_transpose_False (fx.test_gradual_type.TypeCheckerTest) ... ok (0.003s)
2022-08-11T16:20:17.8432205Z   test_type_check_transpose_true (fx.test_gradual_type.TypeCheckerTest) ... ok (0.003s)
2022-08-11T16:20:17.8715984Z   test_type_maxpool2d_fully_static (fx.test_gradual_type.TypeCheckerTest) ... ok (0.028s)
2022-08-11T16:20:17.8756943Z   test_type_typechecl_maxpool2d_3dinput (fx.test_gradual_type.TypeCheckerTest) ... ok (0.004s)
2022-08-11T16:20:17.8857330Z   test_typecheck_basicblock (fx.test_gradual_type.TypeCheckerTest) ... ok (0.010s)
2022-08-11T16:20:17.8858042Z 
2022-08-11T16:20:17.8858537Z ======================================================================
2022-08-11T16:20:17.8859267Z FAIL [0.003s]: test_public_api_surface (__main__.TestFXAPIBackwardCompatibility)
2022-08-11T16:20:17.8860369Z ----------------------------------------------------------------------
2022-08-11T16:20:17.8861339Z Traceback (most recent call last):
2022-08-11T16:20:17.8862049Z   File "/var/lib/jenkins/workspace/test/test_fx.py", line 3814, in test_public_api_surface
2022-08-11T16:20:17.8862929Z     raise AssertionError(f"Public FX API(s) {non_back_compat_strs} introduced but not given a "
2022-08-11T16:20:17.8864704Z AssertionError: Public FX API(s) ['torch.fx.passes.reinplace.reinplace'] introduced but not given a backwards-compatibility classification! Please decorate these API(s) with `@torch.fx._compatibility.compatibility` to specify BC guarantees.
2022-08-11T16:20:17.8865688Z 
2022-08-11T16:20:17.8866173Z ----------------------------------------------------------------------
2022-08-11T16:20:17.8866789Z Ran 1009 tests in 4.099s
2022-08-11T16:20:17.8867086Z 
2022-08-11T16:20:17.8867390Z FAILED (failures=1, skipped=598, expected failures=3)

See GitHub Actions build pull / linux-bionic-py3.7-clang9 / test (crossref, 1, 2, linux.2xlarge) (6/7)

Step: "Test" (full log | diagnosis details)

2022-08-11T16:05:57.8029098Z FAIL [0.002s]: tes..._surface (__main__.TestFXAPIBackwardCompatibility) 
2022-08-11T16:05:57.7362395Z   test_type_check_reshape_false (fx.test_gradual_type.TypeCheckerTest) ... ok (0.003s)
2022-08-11T16:05:57.7395320Z   test_type_check_reshape_true (fx.test_gradual_type.TypeCheckerTest) ... ok (0.003s)
2022-08-11T16:05:57.7573776Z   test_type_check_symbolic_inferenceconv2D_maxpool2d_flatten (fx.test_gradual_type.TypeCheckerTest) ... ok (0.018s)
2022-08-11T16:05:57.7603962Z   test_type_check_transpose_False (fx.test_gradual_type.TypeCheckerTest) ... ok (0.003s)
2022-08-11T16:05:57.7640275Z   test_type_check_transpose_true (fx.test_gradual_type.TypeCheckerTest) ... ok (0.004s)
2022-08-11T16:05:57.7908229Z   test_type_maxpool2d_fully_static (fx.test_gradual_type.TypeCheckerTest) ... ok (0.027s)
2022-08-11T16:05:57.7947519Z   test_type_typechecl_maxpool2d_3dinput (fx.test_gradual_type.TypeCheckerTest) ... ok (0.004s)
2022-08-11T16:05:57.8027682Z   test_typecheck_basicblock (fx.test_gradual_type.TypeCheckerTest) ... ok (0.008s)
2022-08-11T16:05:57.8027981Z 
2022-08-11T16:05:57.8028377Z ======================================================================
2022-08-11T16:05:57.8029098Z FAIL [0.002s]: test_public_api_surface (__main__.TestFXAPIBackwardCompatibility)
2022-08-11T16:05:57.8029977Z ----------------------------------------------------------------------
2022-08-11T16:05:57.8030281Z Traceback (most recent call last):
2022-08-11T16:05:57.8030527Z   File "test_fx.py", line 3814, in test_public_api_surface
2022-08-11T16:05:57.8030853Z     raise AssertionError(f"Public FX API(s) {non_back_compat_strs} introduced but not given a "
2022-08-11T16:05:57.8031615Z AssertionError: Public FX API(s) ['torch.fx.passes.reinplace.reinplace'] introduced but not given a backwards-compatibility classification! Please decorate these API(s) with `@torch.fx._compatibility.compatibility` to specify BC guarantees.
2022-08-11T16:05:57.8039079Z 
2022-08-11T16:05:57.8041643Z ----------------------------------------------------------------------
2022-08-11T16:05:57.8042017Z Ran 1100 tests in 206.462s
2022-08-11T16:05:57.8042194Z 
2022-08-11T16:05:57.8042371Z FAILED (failures=1, skipped=194, expected failures=5)

See GitHub Actions build pull / linux-focal-py3.7-clang7-asan / test (default, 4, 5, linux.2xlarge) (7/7)

Step: "Test" (full log | diagnosis details)

2022-08-11T16:03:35.5964871Z FAIL [0.003s]: tes..._surface (__main__.TestFXAPIBackwardCompatibility) 
2022-08-11T16:03:35.5313444Z   test_type_check_reshape_false (fx.test_gradual_type.TypeCheckerTest) ... ok (0.003s)
2022-08-11T16:03:35.5344459Z   test_type_check_reshape_true (fx.test_gradual_type.TypeCheckerTest) ... ok (0.003s)
2022-08-11T16:03:35.5520020Z   test_type_check_symbolic_inferenceconv2D_maxpool2d_flatten (fx.test_gradual_type.TypeCheckerTest) ... ok (0.018s)
2022-08-11T16:03:35.5551679Z   test_type_check_transpose_False (fx.test_gradual_type.TypeCheckerTest) ... ok (0.003s)
2022-08-11T16:03:35.5582084Z   test_type_check_transpose_true (fx.test_gradual_type.TypeCheckerTest) ... ok (0.003s)
2022-08-11T16:03:35.5840232Z   test_type_maxpool2d_fully_static (fx.test_gradual_type.TypeCheckerTest) ... ok (0.026s)
2022-08-11T16:03:35.5876140Z   test_type_typechecl_maxpool2d_3dinput (fx.test_gradual_type.TypeCheckerTest) ... ok (0.004s)
2022-08-11T16:03:35.5963812Z   test_typecheck_basicblock (fx.test_gradual_type.TypeCheckerTest) ... ok (0.009s)
2022-08-11T16:03:35.5964167Z 
2022-08-11T16:03:35.5964342Z ======================================================================
2022-08-11T16:03:35.5964871Z FAIL [0.003s]: test_public_api_surface (__main__.TestFXAPIBackwardCompatibility)
2022-08-11T16:03:35.5965397Z ----------------------------------------------------------------------
2022-08-11T16:03:35.5965681Z Traceback (most recent call last):
2022-08-11T16:03:35.5966084Z   File "test_fx.py", line 3814, in test_public_api_surface
2022-08-11T16:03:35.5966657Z     raise AssertionError(f"Public FX API(s) {non_back_compat_strs} introduced but not given a "
2022-08-11T16:03:35.5967404Z AssertionError: Public FX API(s) ['torch.fx.passes.reinplace.reinplace'] introduced but not given a backwards-compatibility classification! Please decorate these API(s) with `@torch.fx._compatibility.compatibility` to specify BC guarantees.
2022-08-11T16:03:35.5967803Z 
2022-08-11T16:03:35.5968002Z ----------------------------------------------------------------------
2022-08-11T16:03:35.5968247Z Ran 1002 tests in 10.724s
2022-08-11T16:03:35.5968364Z 
2022-08-11T16:03:35.5968482Z FAILED (failures=1, skipped=198, expected failures=5)
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@bdhirsh bdhirsh mentioned this pull request Aug 11, 2022
Closed
@bdhirsh bdhirsh requested a review from SherlockNoMad August 11, 2022 15:41
@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Sep 26, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/83265

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures, 1 Pending

As of commit 6418932:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@bdhirsh bdhirsh mentioned this pull request Sep 27, 2022
Closed
@bdhirsh bdhirsh mentioned this pull request Sep 28, 2022
Closed
@bdhirsh bdhirsh mentioned this pull request Sep 29, 2022
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 4, 2022

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

Rick0317 pushed a commit to Rick0317/pytorch that referenced this pull request Oct 18, 2022
@bdhirsh
remove BC-guarantee for reinplace pass
637e798 
ghstack-source-id: 1d8f6f4
Pull Request resolved: pytorch/pytorch#83265
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Dec 3, 2022
@github-actions github-actions bot closed this Jan 2, 2023
@facebook-github-bot facebook-github-bot deleted the gh/bdhirsh/296/head branch June 8, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SherlockNoMad SherlockNoMad SherlockNoMad approved these changes

Assignees

No one assigned

Labels

cla signed fx release notes: fx release notes category Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bdhirsh @facebook-github-bot @SherlockNoMad