[ONNX] Remove unused patching methods#83006
Closed
justinchuby wants to merge 4 commits intogh/justinchuby/2/basefrom
Closed
[ONNX] Remove unused patching methods#83006justinchuby wants to merge 4 commits intogh/justinchuby/2/basefrom
justinchuby wants to merge 4 commits intogh/justinchuby/2/basefrom
Conversation
### Description <!-- What did you change and why was it needed? --> Remove unused patching methods: - `torch._C.Graph.constant` - unpatch `torch._C.Node.__getitem__` and move the helper function to `symbolic_helper` Add typing annotations ### Issue <!-- Link to Issue ticket or RFP --> #76254 ### Testing <!-- How did you test your change? --> Unit tested [ghstack-poisoned]
This was referenced Aug 8, 2022
Closed
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit b305518 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Aug 8, 2022
### Description <!-- What did you change and why was it needed? --> Remove unused patching methods: - `torch._C.Graph.constant` - unpatch `torch._C.Node.__getitem__` and move the helper function to `symbolic_helper` Add typing annotations ### Issue <!-- Link to Issue ticket or RFP --> pytorch#76254 ### Testing <!-- How did you test your change? --> Unit tested ghstack-source-id: 2ae9f13 Pull Request resolved: pytorch#83006
### Description <!-- What did you change and why was it needed? --> Remove unused patching methods: - `torch._C.Graph.constant` - unpatch `torch._C.Node.__getitem__` and move the helper function to `symbolic_helper` Add typing annotations ### Issue <!-- Link to Issue ticket or RFP --> #76254 ### Testing <!-- How did you test your change? --> Unit tested [ghstack-poisoned]
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Aug 8, 2022
<!-- What did you change and why was it needed? --> Remove unused patching methods: - `torch._C.Graph.constant` - unpatch `torch._C.Node.__getitem__` and move the helper function to `symbolic_helper` Add typing annotations <!-- Link to Issue ticket or RFP --> <!-- How did you test your change? --> Unit tested ghstack-source-id: d9f2089 Pull Request resolved: pytorch#83006
### Description <!-- What did you change and why was it needed? --> Remove unused patching methods: - `torch._C.Graph.constant` - unpatch `torch._C.Node.__getitem__` and move the helper function to `symbolic_helper` Add typing annotations ### Issue <!-- Link to Issue ticket or RFP --> #76254 ### Testing <!-- How did you test your change? --> Unit tested [ghstack-poisoned]
### Description <!-- What did you change and why was it needed? --> Remove unused patching methods: - `torch._C.Graph.constant` - unpatch `torch._C.Node.__getitem__` and move the helper function to `symbolic_helper` Add typing annotations ### Issue <!-- Link to Issue ticket or RFP --> #76254 ### Testing <!-- How did you test your change? --> Unit tested [ghstack-poisoned]
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Aug 9, 2022
<!-- What did you change and why was it needed? --> Remove unused patching methods: - `torch._C.Graph.constant` - unpatch `torch._C.Node.__getitem__` and move the helper function to `symbolic_helper` Add typing annotations <!-- Link to Issue ticket or RFP --> <!-- How did you test your change? --> Unit tested ghstack-source-id: 795d48e Pull Request resolved: pytorch#83006
BowenBao
reviewed
Aug 9, 2022
BowenBao
reviewed
Aug 9, 2022
| symbolic_caffe2.register_quantized_ops("caffe2", opset_version) | ||
|
|
||
| if ns == "aten": | ||
| if namespace == "aten": |
Collaborator
There was a problem hiding this comment.
nit: Some of these are not related to "Remove unused patching methods"...
Collaborator
Author
There was a problem hiding this comment.
I will break them out
Collaborator
Author
There was a problem hiding this comment.
Actually I will keep them in if you are ok with it, since this function is touched by the removal (https://github.com/pytorch/pytorch/pull/83006/files/b305518f3ed8d57b78dcfcaeb861c6c53c2a5df2#diff-849a5778e2dcf7f36587967273cee0bf20642e35bf4c79405111ea3417c3fb3cR1748-R1751 etc) and a mild clean up doesn't seem too noisy?
Collaborator
Author
There was a problem hiding this comment.
Mark as resolved for this one. I will break changes like this out in the future. Thanks!
BowenBao
approved these changes
Aug 9, 2022
Collaborator
Author
|
@pytorchbot merge |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
Contributor
|
Hey @justinchuby. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 10, 2022
Summary: ### Description <!-- What did you change and why was it needed? --> Remove unused patching methods: - `torch._C.Graph.constant` - unpatch `torch._C.Node.__getitem__` and move the helper function to `symbolic_helper` Add typing annotations ### Issue <!-- Link to Issue ticket or RFP --> #76254 ### Testing <!-- How did you test your change? --> Unit tested Pull Request resolved: #83006 Approved by: https://github.com/BowenBao Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f5701a1f9afc1775bbf259b5fc8b502b17a56288 Reviewed By: seemethere Differential Revision: D38585554 fbshipit-source-id: 810a6f4e8eb83f50f10ed9c48bf0ddd0d3fefec0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Description
Remove unused patching methods:
torch._C.Graph.constanttorch._C.Node.__getitem__and move the helper function tosymbolic_helperAdd typing annotations
Issue
#76254
Testing
Unit tested