[Profiler][Minor] Add typed visit method to Result.#82993
[Profiler][Minor] Add typed visit method to Result.#82993robieta wants to merge 14 commits intogh/robieta/96/basefrom
Conversation
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases. Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/) [ghstack-poisoned]
🔗 Helpful links
❌ 1 New FailuresAs of commit b98d84e (more details on the Dr. CI page): Expand to see more
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases. Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/) ghstack-source-id: 163812822 Pull Request resolved: #82993
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases. Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/) [ghstack-poisoned]
Pull Request resolved: #82993 Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases. ghstack-source-id: 163833756 Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/)
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases. Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/) [ghstack-poisoned]
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases. Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/) [ghstack-poisoned]
|
@pytorchbot merge -l |
|
@pytorchbot successfully started a merge and created land time checks. See merge status here and land check progress here. |
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases. Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/) Pull Request resolved: #82993 Approved by: https://github.com/chaekit
|
Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule superuser |
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases. Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/) [ghstack-poisoned]
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases. Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/) [ghstack-poisoned]
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases. Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/) [ghstack-poisoned]
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases. Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/) [ghstack-poisoned]
|
@pytorchbot merge -l |
|
Merge failed due to Refusing to merge as mandatory check(s) pull are pending/not yet run for rule superuser |
|
@pytorchbot merge -g |
|
@pytorchbot merge |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
Merge failed due to Command Raised by https://github.com/pytorch/pytorch/actions/runs/2834024571 |
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases. Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/) [ghstack-poisoned]
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases. Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/) [ghstack-poisoned]
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases. Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/) [ghstack-poisoned]
|
@pytorchbot merge -l |
|
@pytorchbot successfully started a merge job. Check the current status here. |
|
Merge failed |
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases. Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/) [ghstack-poisoned]
|
@pytorchbot merge -l |
|
@pytorchbot successfully started a merge job. Check the current status here. |
|
Merge failed |
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases. Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/) [ghstack-poisoned]
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases. Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/) [ghstack-poisoned]
Summary: Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases. Pull Request resolved: #82993 Approved by: https://github.com/chaekit Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f295dd0735e05146106d6fc25df1449ff76d078b Original Phabricator Test Plan: There should be no functionality change, so existing unit tests are sufficient. Reviewed By: chaekit, seemethere Differential Revision: D38426341 Pulled By: robieta fbshipit-source-id: 7145cb82bc2989819d9f5815d525b0401086470d
Stack from ghstack (oldest at bottom):
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases.
Differential Revision: D38426341