Skip to content

[Profiler][Minor] Add typed visit method to Result.#82993

Closed
robieta wants to merge 14 commits intogh/robieta/96/basefrom
gh/robieta/96/head
Closed

[Profiler][Minor] Add typed visit method to Result.#82993
robieta wants to merge 14 commits intogh/robieta/96/basefrom
gh/robieta/96/head

Conversation

@robieta
Copy link
Contributor

@robieta robieta commented Aug 8, 2022

Stack from ghstack (oldest at bottom):

Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases.

Differential Revision: D38426341

Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases.

Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 8, 2022

🔗 Helpful links

❌ 1 New Failures

As of commit b98d84e (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-docs / build-docs (python) (1/1)

Step: "Unknown" (full log | diagnosis details)

2022-08-20T07:56:11.5777598Z ##[error]The operation was canceled.
2022-08-20T02:02:05.5225103Z copying images... [ 97%] _static/img/tensorboard/add_images.png
2022-08-20T02:02:05.5226958Z copying images... [100%] _static/img/tensorboard/add_hparam.png
2022-08-20T02:02:05.5228396Z 
2022-08-20T02:02:05.5458979Z copying static files... done
2022-08-20T02:02:05.5459624Z copying extra files... done
2022-08-20T02:02:05.9691155Z dumping search index in English (code: en)... done
2022-08-20T02:02:06.0729670Z dumping object inventory... done
2022-08-20T02:02:06.0732529Z build succeeded.
2022-08-20T02:02:06.0734150Z 
2022-08-20T02:02:06.0734470Z The HTML pages are in build/html.
2022-08-20T07:56:11.5777598Z ##[error]The operation was canceled.
2022-08-20T07:56:11.5798676Z Prepare all required actions
2022-08-20T07:56:11.5814758Z ##[group]Run ./.github/actions/chown-workspace
2022-08-20T07:56:11.5814973Z ##[endgroup]
2022-08-20T07:56:11.5836962Z ##[group]Run docker run --rm -v "$(pwd)":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" .
2022-08-20T07:56:11.5837302Z �[36;1mdocker run --rm -v "$(pwd)":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" .�[0m
2022-08-20T07:56:11.5847378Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2022-08-20T07:56:11.5847583Z env:
2022-08-20T07:56:11.5847817Z   ALPINE_IMAGE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/tool/alpine
2022-08-20T07:56:11.5848060Z ##[endgroup]
2022-08-20T07:56:13.0698428Z Post job cleanup.

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

robieta pushed a commit that referenced this pull request Aug 8, 2022
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases.

Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/)

ghstack-source-id: 163812822
Pull Request resolved: #82993
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases.

Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/)

[ghstack-poisoned]
robieta pushed a commit that referenced this pull request Aug 8, 2022
Pull Request resolved: #82993

Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases.
ghstack-source-id: 163833756

Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/)
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases.

Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/)

[ghstack-poisoned]
@robieta robieta requested a review from chaekit August 8, 2022 21:32
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases.

Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/)

[ghstack-poisoned]
@robieta
Copy link
Contributor Author

robieta commented Aug 8, 2022

@pytorchbot merge -l

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge and created land time checks. See merge status here and land check progress here.

pytorchmergebot pushed a commit that referenced this pull request Aug 8, 2022
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases.

Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/)
Pull Request resolved: #82993
Approved by: https://github.com/chaekit
@pytorchmergebot
Copy link
Collaborator

Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2821700754 If you believe this is an error, you can use the old behavior with @pytorchbot merge -g (optionally with the "ciflow/trunk" to get land signals) or use @pytorchbot merge -f "some reason here". For more information, see the bot wiki.

Taylor Robie added 4 commits August 9, 2022 13:08
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases.

Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/)

[ghstack-poisoned]
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases.

Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/)

[ghstack-poisoned]
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases.

Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/)

[ghstack-poisoned]
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases.

Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/)

[ghstack-poisoned]
@robieta
Copy link
Contributor Author

robieta commented Aug 10, 2022

@pytorchbot merge -l

@pytorchmergebot
Copy link
Collaborator

Merge failed due to Refusing to merge as mandatory check(s) pull are pending/not yet run for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2829186158 If you believe this is an error, you can use the old behavior with @pytorchbot merge -g (optionally with the "ciflow/trunk" to get land signals) or use @pytorchbot merge -f "some reason here". For more information, see the bot wiki.

@robieta robieta added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Aug 10, 2022
@robieta
Copy link
Contributor Author

robieta commented Aug 10, 2022

@pytorchbot merge -g

@robieta
Copy link
Contributor Author

robieta commented Aug 10, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Merge failed due to Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x d3d2bd1f1a1830fdf00fb273ffd2d7f14cb4a336 returned non-zero exit code 1

Auto-merging torch/csrc/autograd/init.cpp
CONFLICT (content): Merge conflict in torch/csrc/autograd/init.cpp
error: could not apply d3d2bd1f1a... [Profiler] Start moving python bindings out of autograd
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Raised by https://github.com/pytorch/pytorch/actions/runs/2834024571

Taylor Robie added 3 commits August 17, 2022 12:55
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases.

Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/)

[ghstack-poisoned]
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases.

Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/)

[ghstack-poisoned]
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases.

Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/)

[ghstack-poisoned]
@robieta
Copy link
Contributor Author

robieta commented Aug 18, 2022

@pytorchbot merge -l

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the land checks (-l) flag. If you did not specify this flag yourself, you are likely enrolled in the land checks rollout. This means that your change will be merged once all checks on your PR have passed since you have added the ciflow/trunk label to your PR (ETA 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@pytorchmergebot
Copy link
Collaborator

Merge failed
Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-bionic-cuda10.2-py3.9-gcc7 / test (default, 1, 4, linux.4xlarge.nvidia.gpu)
Raised by https://github.com/pytorch/pytorch/actions/runs/2885882594 If you believe this is an error, you can use the old behavior with @pytorchbot merge -g (optionally with the ciflow/trunk to get land checks) or use @pytorchbot merge -f "some reason here". For more information, see the bot wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases.

Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/)

[ghstack-poisoned]
@robieta
Copy link
Contributor Author

robieta commented Aug 19, 2022

@pytorchbot merge -l

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the land checks (-l) flag. If you did not specify this flag yourself, you are likely enrolled in the land checks rollout. This means that your change will be merged once all checks on your PR have passed since you have added the ciflow/trunk label to your PR (ETA 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@pytorchmergebot
Copy link
Collaborator

Merge failed
Reason: Refusing to merge as mandatory check(s) pull failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2890373603 If you believe this is an error, you can use the old behavior with @pytorchbot merge -g (optionally with the ciflow/trunk to get land checks) or use @pytorchbot merge -f "some reason here". For more information, see the bot wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@robieta robieta removed ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Aug 19, 2022
Taylor Robie added 2 commits August 19, 2022 12:06
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases.

Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/)

[ghstack-poisoned]
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases.

Differential Revision: [D38426341](https://our.internmc.facebook.com/intern/diff/D38426341/)

[ghstack-poisoned]
@robieta robieta added the release notes: profiler release notes category label Aug 21, 2022
facebook-github-bot pushed a commit that referenced this pull request Aug 23, 2022
Summary:
Often in post processing we want to step into a specific typed context: "If X is a torch op, do Y". This PR simply adds an ergonomic way to write such cases.

Pull Request resolved: #82993
Approved by: https://github.com/chaekit

Test Plan:
contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f295dd0735e05146106d6fc25df1449ff76d078b

Original Phabricator Test Plan:
There should be no functionality change, so existing unit tests are sufficient.

Reviewed By: chaekit, seemethere

Differential Revision: D38426341

Pulled By: robieta

fbshipit-source-id: 7145cb82bc2989819d9f5815d525b0401086470d
@facebook-github-bot facebook-github-bot deleted the gh/robieta/96/head branch August 24, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants