Add a common wrapper for make_fx to handle args and kwargs#82965
Closed
IvanYashchuk wants to merge 1 commit intopytorch:masterfrom
Closed
Add a common wrapper for make_fx to handle args and kwargs#82965IvanYashchuk wants to merge 1 commit intopytorch:masterfrom
IvanYashchuk wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit d3196ba (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
ngimel
approved these changes
Aug 8, 2022
Collaborator
ngimel
left a comment
There was a problem hiding this comment.
Cool, thanks for the fix
Collaborator
Author
|
@pytorchbot merge -g |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
…82965) Summary: Added a helper function `wrapper_and_args_for_make_fx` since a number of places we use `make_fx` internally might grow. Pull Request resolved: #82965 Approved by: https://github.com/ngimel Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/ea391465073c9b61d21db414516e70b4359c237d Reviewed By: seemethere Differential Revision: D38542259 Pulled By: seemethere fbshipit-source-id: e34dbebf3f6589fb7a4fb3a8ef677608afc0506a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a helper function
wrapper_and_args_for_make_fxsince a number of places we usemake_fxinternally might grow.