[tensorboard] Remove dependence on torch.onnx by justinchuby · Pull Request #82628 · pytorch/pytorch

justinchuby · 2022-08-02T00:26:02Z

Description

The graph function takes a dependency on torch.onnx.select_model_mode_for_export, which was used because it implicitly patches torch._C.Node to allow for key access. This change removed the need for the patch and decoupled the tensorboard util from torch.onnx.

This is needed to unblock #82511 because we are removing the monkey patch

Issue

Testing

cc @ezyang @orionr @BowenBao

facebook-github-bot · 2022-08-02T00:26:08Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/82628
📄 Preview Python docs built from this PR
❌ C++ docsfailed to build
❓Need help or want to give feedback on the CI? Visit our office hours

❌ 1 New Failures

As of commit a39934d (more details on the Dr. CI page):

Expand to see more

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

pull / linux-docs / build-docs (cpp) (1/1)

Step: "Build cpp docs" (full log | diagnosis details)

2022-08-02T16:35:07.1871121Z ##[error]Process completed with exit code 137.

2022-08-02T16:28:52.3080874Z �[01mwriting output... �[39;49;00m[ 90%] �[32mapi/structat_1_1native_1_1_descriptor_deleter .. api/structtorch_1_1enumtype_1_1k_conv_transpose3_d�[39;49;00m
2022-08-02T16:29:01.3764158Z �[01mwriting output... �[39;49;00m[ 92%] �[32mapi/structtorch_1_1enumtype_1_1k_fan_in .. api/structtorch_1_1nn_1_1_huber_loss_options�[39;49;00m
2022-08-02T16:29:18.8285946Z �[01mwriting output... �[39;49;00m[ 93%] �[32mapi/structtorch_1_1nn_1_1_instance_norm_options .. api/structtorch_1_1nn_1_1functional_1_1_normalize_func_options�[39;49;00m
2022-08-02T16:29:26.1796679Z �[01mwriting output... �[39;49;00m[ 95%] �[32mapi/structtorch_1_1nn_1_1functional_1_1_pad_func_options .. api/typedef_namespacetorch_1_1nn_1_1functional_1a872abe58e376dc403b3bea4259d4d2b5�[39;49;00m
2022-08-02T16:29:30.8237899Z �[01mwriting output... �[39;49;00m[ 96%] �[32mapi/typedef_namespacetorch_1_1nn_1_1functional_1a8c6ad6948f1e1c554bc731c5d7081408 .. api/typedef_namespacetorch_1_1python_1_1detail_1a9808c29bfe27f974414c895b4ff37f2f�[39;49;00m
2022-08-02T16:29:43.0310762Z �[01mwriting output... �[39;49;00m[ 98%] �[32mapi/typedef_namespacetorch_1a23e4c6c3b3c89d2a8051db46fc003159 .. api/variable_namespacetorch_1aeaf16f038962bbc7c4a0f57696fa3fb1�[39;49;00m
2022-08-02T16:29:45.0499923Z �[01mwriting output... �[39;49;00m[100%] �[32mapi/variable_namespacetorch_1aec4dc7ff45a796efc14a599c307a9d10 .. notes/versioning�[39;49;00m
2022-08-02T16:29:45.0500418Z 
2022-08-02T16:29:45.0575092Z �[01mwaiting for workers...�[39;49;00m
2022-08-02T16:35:07.1232477Z /home/ec2-user/actions-runner/_work/_temp/a10b72ba-25f7-44a3-8c68-609ae0a86b87.sh: line 28: 14118 Killed                  docker exec -t "${container_name}" bash -c "sudo chown -R jenkins . && pip install dist/*.whl && ./.circleci/scripts/${DOCS_TYPE}_doc_push_script.sh"
2022-08-02T16:35:07.1871121Z ##[error]Process completed with exit code 137.
2022-08-02T16:35:07.2278748Z Prepare all required actions
2022-08-02T16:35:07.2354290Z ##[group]Run ./.github/actions/chown-workspace
2022-08-02T16:35:07.2354679Z ##[endgroup]
2022-08-02T16:35:07.2378871Z ##[group]Run docker run --rm -v "$(pwd)":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" .
2022-08-02T16:35:07.2379520Z �[36;1mdocker run --rm -v "$(pwd)":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" .�[0m
2022-08-02T16:35:07.3520520Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2022-08-02T16:35:07.3520971Z env:
2022-08-02T16:35:07.3521436Z   ALPINE_IMAGE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/tool/alpine
2022-08-02T16:35:07.3521882Z ##[endgroup]
2022-08-02T16:35:07.9815456Z Unable to find image '308535385114.dkr.ecr.us-east-1.amazonaws.com/tool/alpine:latest' locally

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

ezyang

sure

justinchuby · 2022-08-02T14:57:18Z

@pytorchbot merge -g

justinchuby · 2022-08-02T14:57:47Z

thanks for the review!

pytorchmergebot · 2022-08-02T14:58:31Z

@pytorchbot successfully started a merge job. Check the current status here

pytorchmergebot · 2022-08-02T16:39:02Z

Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2783117532

justinchuby · 2022-08-02T17:14:25Z

@pytorchbot merge -f "This PR is unrelated to the cpp doc failures"

pytorchmergebot · 2022-08-02T17:18:27Z

@pytorchbot successfully started a merge job. Check the current status here

github-actions · 2022-08-02T17:22:59Z

Hey @justinchuby.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: ### Description  The `graph` function takes a dependency on `torch.onnx.select_model_mode_for_export`, which was used because it implicitly patches `torch._C.Node` to allow for key access. This change removed the need for the patch and decoupled the tensorboard util from `torch.onnx`. This is needed to unblock #82511 because we are removing the monkey patch ### Issue  ### Testing  cc ezyang orionr BowenBao Pull Request resolved: #82628 Approved by: https://github.com/ezyang Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/c7dde7da6d27d81555e44d9f9e416b81697b02d5 Reviewed By: kit1980 Differential Revision: D38359651 fbshipit-source-id: d2c3e4f0db75b54d224e11c76830ca642edaa2e9

Attribute access with subscripting would previously work due to patching in pytorch/pytorch#82511 but this has been removed. This commit uses the fix proposed in pytorch/pytorch#82628 to define a helper method to call the appropriate access method.

As seen in pytorch/pytorch#82628. This should remove the `TypeError: 'torch._C.Node' object is not subscriptable` error.

As seen in pytorch/pytorch#82628. This removes the `TypeError: 'torch._C.Node' object is not subscriptable` error.

Attribute access with subscripting would previously work due to patching in pytorch/pytorch#82511 but this has been removed. This commit uses the fix proposed in pytorch/pytorch#82628 to define a helper method to call the appropriate access method.

As seen in pytorch/pytorch#82628. This removes the `TypeError: 'torch._C.Node' object is not subscriptable` error.

Attribute access with subscripting would previously work due to patching in pytorch/pytorch#82511 but this has been removed. This commit uses the fix proposed in pytorch/pytorch#82628 to define a helper method to call the appropriate access method.

[tensorboard] Remove dependence to torch.onnx

a39934d

facebook-github-bot added the cla signed label Aug 2, 2022

justinchuby requested a review from orionr August 2, 2022 00:29

justinchuby added module: tensorboard module: onnx Related to torch.onnx labels Aug 2, 2022

pytorchbot added the open source label Aug 2, 2022

justinchuby mentioned this pull request Aug 2, 2022

[ONNX] Remove unused patching methods #82511

Closed

justinchuby requested a review from ezyang August 2, 2022 04:02

ezyang approved these changes Aug 2, 2022

View reviewed changes

pytorchmergebot added the Merged label Aug 2, 2022

pytorchmergebot closed this in c7dde7d Aug 2, 2022

jamt9000 mentioned this pull request Jul 6, 2023

Fix torch._C.Node attribute access openai/CLIP#372

Merged

vepadulano added a commit to vepadulano/root that referenced this pull request Sep 6, 2023

[TMVA] Remove dependency on torch.onnx submodule

54d8941

As seen in pytorch/pytorch#82628. This should remove the `TypeError: 'torch._C.Node' object is not subscriptable` error.

vepadulano added a commit to vepadulano/root that referenced this pull request Sep 6, 2023

[TMVA] Remove dependency on torch.onnx submodule

10b7304

As seen in pytorch/pytorch#82628. This should remove the `TypeError: 'torch._C.Node' object is not subscriptable` error.

vepadulano added a commit to vepadulano/root that referenced this pull request Sep 6, 2023

[TMVA] Remove dependency on torch.onnx submodule

102aedd

As seen in pytorch/pytorch#82628. This removes the `TypeError: 'torch._C.Node' object is not subscriptable` error.

vepadulano added a commit to root-project/root that referenced this pull request Sep 12, 2023

[TMVA] Remove dependency on torch.onnx submodule

c1dbe06

As seen in pytorch/pytorch#82628. This removes the `TypeError: 'torch._C.Node' object is not subscriptable` error.

guitargeek pushed a commit to guitargeek/root that referenced this pull request Oct 2, 2023

[TMVA] Remove dependency on torch.onnx submodule

a2dcbf7

As seen in pytorch/pytorch#82628. This removes the `TypeError: 'torch._C.Node' object is not subscriptable` error.

guitargeek pushed a commit to root-project/root that referenced this pull request Oct 2, 2023

[TMVA] Remove dependency on torch.onnx submodule

b3b46b5

As seen in pytorch/pytorch#82628. This removes the `TypeError: 'torch._C.Node' object is not subscriptable` error.

maksgraczyk pushed a commit to maksgraczyk/root that referenced this pull request Jan 12, 2024

[TMVA] Remove dependency on torch.onnx submodule

154c4d4

As seen in pytorch/pytorch#82628. This removes the `TypeError: 'torch._C.Node' object is not subscriptable` error.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tensorboard] Remove dependence on torch.onnx#82628

[tensorboard] Remove dependence on torch.onnx#82628
justinchuby wants to merge 1 commit intopytorch:masterfrom
justinchuby:justinchu/tensorboard-onnx-decouple

justinchuby commented Aug 2, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented Aug 2, 2022 •

edited

Loading

🕵️ 1 new failure recognized by patterns

pull / linux-docs / build-docs (cpp) (1/1)

Uh oh!

ezyang left a comment

Uh oh!

justinchuby commented Aug 2, 2022

Uh oh!

justinchuby commented Aug 2, 2022

Uh oh!

pytorchmergebot commented Aug 2, 2022

Uh oh!

pytorchmergebot commented Aug 2, 2022

Uh oh!

justinchuby commented Aug 2, 2022

Uh oh!

pytorchmergebot commented Aug 2, 2022

Uh oh!

github-actions bot commented Aug 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

justinchuby commented Aug 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue

Testing

Uh oh!

facebook-github-bot commented Aug 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

❌ 1 New Failures

🕵️ 1 new failure recognized by patterns

pull / linux-docs / build-docs (cpp) (1/1)

Uh oh!

ezyang left a comment

Choose a reason for hiding this comment

Uh oh!

justinchuby commented Aug 2, 2022

Uh oh!

justinchuby commented Aug 2, 2022

Uh oh!

pytorchmergebot commented Aug 2, 2022

Uh oh!

pytorchmergebot commented Aug 2, 2022

Uh oh!

justinchuby commented Aug 2, 2022

Uh oh!

pytorchmergebot commented Aug 2, 2022

Uh oh!

github-actions bot commented Aug 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

justinchuby commented Aug 2, 2022 •

edited

Loading

facebook-github-bot commented Aug 2, 2022 •

edited

Loading