Skip to content

Remove unecesary copy constructor#82626

Closed
skrobchik wants to merge 0 commit intopytorch:masterfrom
skrobchik:export-D38221240
Closed

Remove unecesary copy constructor#82626
skrobchik wants to merge 0 commit intopytorch:masterfrom
skrobchik:export-D38221240

Conversation

@skrobchik
Copy link
Copy Markdown

@skrobchik skrobchik commented Aug 1, 2022

Summary:
This is deprecated and blocks compilation of this diff:
D38221239

Test Plan:
arc test diff
maui install workvc
Check that call works

Differential Revision: D38221240

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 1, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (15 Pending)

As of commit 0fd990e (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 1, 2022

This pull request was exported from Phabricator. Differential Revision: D38221240

@osalpekar
Copy link
Copy Markdown
Contributor

osalpekar commented Aug 2, 2022

Thanks for contributing!

@osalpekar
Copy link
Copy Markdown
Contributor

osalpekar commented Aug 2, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Aug 2, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 2, 2022

Hey @skrobchik.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@zengk95
Copy link
Copy Markdown
Contributor

zengk95 commented Aug 2, 2022

@pytorchbot revert -m "This looks like its breaking trunk" -c landrace

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Aug 2, 2022

@pytorchbot successfully started a revert job. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Aug 2, 2022

@skrobchik your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Aug 2, 2022
@pytorchmergebot
Revert "Remove unecesary copy constructor (#82626)"
dba287e 
This reverts commit 714669e.

Reverted #82626 on behalf of https://github.com/zengk95 due to This looks like its breaking trunk
@skrobchik skrobchik reopened this Aug 2, 2022
@skrobchik
Copy link
Copy Markdown
Author

skrobchik commented Aug 2, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Aug 2, 2022

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Aug 2, 2022

Successfully rebased export-D38221240 onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout export-D38221240 && git pull --rebase)

facebook-github-bot pushed a commit that referenced this pull request Aug 3, 2022
@facebook-github-bot
Remove unecesary copy constructor (#82626) (#82626)
7ad3707 
Summary:
This is deprecated and blocks compilation of this diff:
D38221239

Pull Request resolved: #82626
Approved by: https://github.com/kit1980, https://github.com/osalpekar

Test Plan:
contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/714669e22dafde735ab683eee1f37baf7cd39879

Test plan from GitHub:
`arc test diff`
`maui install workvc`
Check that call works

Original Phabricator Test Plan:
`arc test diff`
`maui install workvc`
Check that call works

Reviewed By: kit1980, osalpekar

Differential Revision: D38221240

Pulled By: skrobchik

fbshipit-source-id: dfa3e91b284b069906d8a89989ab2307007e31de
facebook-github-bot pushed a commit that referenced this pull request Aug 4, 2022
@pytorchmergebot @facebook-github-bot
Revert "Remove unecesary copy constructor (#82626)"
66b53fa 
Summary:
This reverts commit 714669e.

Reverted #82626 on behalf of https://github.com/zengk95 due to This looks like its breaking trunk

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/dba287ed116adf95d77c0908280b7f52e7a83be2

Reviewed By: kit1980

Differential Revision: D38394696

fbshipit-source-id: 73300f8a279bab11a0a76035893c9c5d5ff95d2a
malfet added a commit that referenced this pull request Aug 8, 2022
@malfet
Remove unnecessary copy constructor
45268e6 
Re-land of #82626 which somehow broke deploy build
@malfet malfet mentioned this pull request Aug 8, 2022
Closed
pytorchmergebot pushed a commit that referenced this pull request Aug 9, 2022
@malfet @pytorchmergebot
Remove unnecessary copy constructor (#83030)
c6bc766 
Re-land of #82626 which somehow broke deploy build
Fixes annoying warnings when building with clang:
```
../c10/util/variant.h:2256:9: warning: definition of implicit copy constructor for 'impl<c10::Scalar, c10::basic_string_view<char>>' is deprecated because it has a user-declared copy assignment operator [-Wdeprecated-copy]
  impl& operator=(const impl& other) = default;
        ^
```

Preliminary step for switching MacOS builds to ones with `-Werror`
Pull Request resolved: #83030
Approved by: https://github.com/kit1980, https://github.com/seemethere
facebook-github-bot pushed a commit that referenced this pull request Aug 9, 2022
@malfet @facebook-github-bot
Remove unnecessary copy constructor (#83030) (#83030)
df4a361 
Summary:
Re-land of #82626 which somehow broke deploy build
Fixes annoying warnings when building with clang:
```
../c10/util/variant.h:2256:9: warning: definition of implicit copy constructor for 'impl<c10::Scalar, c10::basic_string_view<char>>' is deprecated because it has a user-declared copy assignment operator [-Wdeprecated-copy]
  impl& operator=(const impl& other) = default;
        ^
```

Preliminary step for switching MacOS builds to ones with `-Werror`

Pull Request resolved: #83030
Approved by: https://github.com/kit1980, https://github.com/seemethere

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/c6bc766184cf149da21f959c19997bc93f3c1f4f

Reviewed By: seemethere

Differential Revision: D38542661

Pulled By: malfet

fbshipit-source-id: 741e53dca2a3076337e947667e3dacca14832358
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@pytorchmergebot
Remove unecesary copy constructor (pytorch#82626)
7c58599 
Summary:
This is deprecated and blocks compilation of this diff:
D38221239

Test Plan:
`arc test diff`
`maui install workvc`
Check that call works

Differential Revision: D38221240

Pull Request resolved: pytorch#82626
Approved by: https://github.com/kit1980, https://github.com/osalpekar
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@pytorchmergebot
Revert "Remove unecesary copy constructor (pytorch#82626)"
c43d315 
This reverts commit 7c58599.

Reverted pytorch#82626 on behalf of https://github.com/zengk95 due to This looks like its breaking trunk
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@malfet @pytorchmergebot
Remove unnecessary copy constructor (pytorch#83030)
08ac254 
Re-land of pytorch#82626 which somehow broke deploy build
Fixes annoying warnings when building with clang:
```
../c10/util/variant.h:2256:9: warning: definition of implicit copy constructor for 'impl<c10::Scalar, c10::basic_string_view<char>>' is deprecated because it has a user-declared copy assignment operator [-Wdeprecated-copy]
  impl& operator=(const impl& other) = default;
        ^
```

Preliminary step for switching MacOS builds to ones with `-Werror`
Pull Request resolved: pytorch#83030
Approved by: https://github.com/kit1980, https://github.com/seemethere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@kit1980 kit1980 kit1980 approved these changes

@osalpekar osalpekar osalpekar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed fb-exported Merged Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@skrobchik @facebook-github-bot @osalpekar @pytorchmergebot @zengk95 @kit1980