CoreML backend should log on failure not success#82604
CoreML backend should log on failure not success#82604jmdetloff wants to merge 1 commit intopytorch:masterfrom
Conversation
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 7d80acb (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@jmdetloff has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
Hey @jmdetloff. |
Summary: ### Description The original intention of this code was to log whenever inference fails, not whenever it succeeds. This change updates the logic of should_log to match this intention. Pull Request resolved: #82604 Test Plan: One line log fix. Build, run tests, and lint. Reviewed By: SS-JIA, kirklandsign Differential Revision: D38327492 Pulled By: jmdetloff fbshipit-source-id: 710a59670a76b6f756501cc97373e81a955f5328
Description
The original intention of this code was to log whenever inference fails, not whenever it succeeds. This change updates the logic of should_log to match this intention.