[FSDP] Implement _param_fqns() to return all parameter FQNs for the FSDP module#82595
[FSDP] Implement _param_fqns() to return all parameter FQNs for the FSDP module#82595fegin wants to merge 2 commits intogh/fegin/19/basefrom
Conversation
…SDP module _param_fqns() returns the (fqn, param_name, module_name) tuple for all the parameters wrapped by the current FSDP module. Differential Revision: [D38325223](https://our.internmc.facebook.com/intern/diff/D38325223/) [ghstack-poisoned]
🔗 Helpful links
✅ No Failures (0 Pending)As of commit e2fdfb9 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…s for the FSDP module" _param_fqns() returns the (fqn, param_name, module_name) tuple for all the parameters wrapped by the current FSDP module. Differential Revision: [D38325223](https://our.internmc.facebook.com/intern/diff/D38325223/) [ghstack-poisoned]
…SDP module Pull Request resolved: #82595 _param_fqns() returns the (fqn, param_name, module_name) tuple for all the parameters wrapped by the current FSDP module. ghstack-source-id: 163183717 Differential Revision: [D38325223](https://our.internmc.facebook.com/intern/diff/D38325223/)
| set(spi.module for spi in self.flat_param._shared_param_infos) | ||
| ) | ||
|
|
||
| def parameter_module_names(self) -> Iterator[Tuple[str, str]]: |
There was a problem hiding this comment.
nit: docstring mentioning what is returned here?
There was a problem hiding this comment.
Miss this comment, will have another PR to fix the docstring.
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
1 similar comment
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
Hey @fegin. |
…SDP module (#82595) Summary: Pull Request resolved: #82595 _param_fqns() returns the (fqn, param_name, module_name) tuple for all the parameters wrapped by the current FSDP module. ghstack-source-id: 163183717 Test Plan: CI Reviewed By: rohan-varma Differential Revision: D38325223 fbshipit-source-id: 4aa143f20a105e6b70ab5fbe6299642fc3917fcb
Stack from ghstack (oldest at bottom):
_param_fqns() returns the (fqn, param_name, module_name) tuple for all the parameters wrapped by the current FSDP module.
Differential Revision: D38325223