Fix false positive AVX, AVX2 and AVX512 detection with MSVC#82554
Fix false positive AVX, AVX2 and AVX512 detection with MSVC#82554JohT wants to merge 1 commit intopytorch:masterfrom
Conversation
|
Hi @JohT! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 697afd5 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
malfet
left a comment
There was a problem hiding this comment.
LGTM, provided it passes M1 cross-compilation (I remember had to revert several runs back to compiles)
|
@pytorchbot merge |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
Hey @JohT. |
|
@pytorchbot label release notes: cpp |
|
Didn't find following labels among repository labels: release,notes:,cpp |
|
@pytorchbot label "release notes: cpp" |
|
@pytorchbot label "topic: bug fixes" |
…82554) Summary: ### Description These changes were made to assure, that the code that tests the vector instruction set extensions not only compiles but also runs to detect it properly for MSVC: - INCLUDE(CheckCSourceRuns) instead of INCLUDE(CheckCSourceCompiles) - INCLUDE(CheckCXXSourceRuns) instead of INCLUDE(CheckCXXSourceCompiles) - CHECK_C_SOURCE_RUNS instead of CHECK_C_SOURCE_COMPILES - CHECK_CXX_SOURCE_RUNS instead of CHECK_CXX_SOURCE_COMPILES ### Issue #82553 ### Testing I tried the [code changes](JohT/convolution-benchmarks@86246b3) on a copy of [FindAVX.cmake](https://github.com/pytorch/pytorch/blob/master/cmake/Modules/FindAVX.cmake) in my repository [convolution-benchmarks](https://github.com/JohT/convolution-benchmarks) and could verify that the detection works properly now. Pull Request resolved: #82554 Approved by: https://github.com/malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/2ffb23616d5b24903558784678a3cdfd263ba155 Reviewed By: kit1980 Differential Revision: D38359391 fbshipit-source-id: 826c1bb30d640f36526af464746eaa6b573ccd95
Description
These changes were made to assure, that the code that tests the vector instruction set extensions not only compiles but also runs to detect it properly for MSVC:
Issue
#82553
Testing
I tried the code changes on a copy of FindAVX.cmake in my repository convolution-benchmarks and could verify that the detection works properly now.