Skip to content

Add check() to FileCheck type stub.#82516

Closed
zhxchen17 wants to merge 1 commit intopytorch:masterfrom
zhxchen17:export-D38294263
Closed

Add check() to FileCheck type stub.#82516
zhxchen17 wants to merge 1 commit intopytorch:masterfrom
zhxchen17:export-D38294263

Conversation

@zhxchen17
Copy link
Contributor

@zhxchen17 zhxchen17 commented Jul 30, 2022

Summary: check() is missing from FileCheck stub.

Test Plan: CI

Differential Revision: D38294263

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 30, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit e607908 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 30, 2022

This pull request was exported from Phabricator. Differential Revision: D38294263

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 30, 2022

This pull request was exported from Phabricator. Differential Revision: D38294263

@zhxchen17 @facebook-github-bot
Add check() and check_not() to FileCheck type stub. (pytorch#82516)
e607908 
Summary:
Pull Request resolved: pytorch#82516

check() and check_not() is missing from FileCheck stub.

Test Plan: CI

Differential Revision: D38294263

fbshipit-source-id: ed8421191e8fcbabe1712d7211a0013845aaad21
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 1, 2022

This pull request was exported from Phabricator. Differential Revision: D38294263

@zhxchen17
Copy link
Contributor Author

zhxchen17 commented Aug 1, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 1, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Hey @zhxchen17.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@zhxchen17 zhxchen17 added the topic: not user facing topic category label Aug 1, 2022
facebook-github-bot pushed a commit that referenced this pull request Aug 3, 2022
@zhxchen17 @facebook-github-bot
Add check() to FileCheck type stub. (#82516) (#82516)
6680975 
Summary:
check() is missing from FileCheck stub.

Pull Request resolved: #82516
Approved by: https://github.com/angelayi, https://github.com/qihqi

Test Plan:
contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/b8c1aa813c8b6647cea24929355555d6ab92159c

Test plan from GitHub:
CI

Original Phabricator Test Plan:
CI

Reviewed By: qihqi, kit1980, angelayi

Differential Revision: D38294263

Pulled By: zhxchen17

fbshipit-source-id: ed174ad1a4a03fcdb90d30402acef34b63841ee9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angelayi angelayi angelayi approved these changes

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan

@nikithamalgifb nikithamalgifb Awaiting requested review from nikithamalgifb

+1 more reviewer

@qihqi qihqi qihqi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed fb-exported Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zhxchen17 @facebook-github-bot @pytorchmergebot @qihqi @angelayi