Skip to content

Replace SymIntTable with directly storing pointer in SymInt#82468

Closed
ezyang wants to merge 5 commits intogh/ezyang/1299/basefrom
gh/ezyang/1299/head
Closed

Replace SymIntTable with directly storing pointer in SymInt#82468
ezyang wants to merge 5 commits intogh/ezyang/1299/basefrom
gh/ezyang/1299/head

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Jul 29, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Signed-off-by: Edward Z. Yang ezyang@fb.com

@ezyang
Replace SymIntTable with directly storing pointer in SymInt
a34816c 
Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
This was referenced Jul 29, 2022
Closed
Closed
ezyang added a commit that referenced this pull request Jul 29, 2022
@ezyang
Replace SymIntTable with directly storing pointer in SymInt
91ebad1 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: 6103b07
Pull Request resolved: #82468
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 29, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit def7bc4 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@ezyang
Update on "Replace SymIntTable with directly storing pointer in SymInt"
2f855bb 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
This was referenced Aug 1, 2022
Closed
Closed
Closed
@ezyang
Update on "Replace SymIntTable with directly storing pointer in SymInt"
e3eb5e3 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Aug 1, 2022
@ezyang
Replace SymIntTable with directly storing pointer in SymInt
1796bc8 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: 02ab994
Pull Request resolved: #82468
@ezyang ezyang requested review from Chillee, Krovatkin, bdhirsh and suo August 1, 2022 04:03
@ezyang
Update on "Replace SymIntTable with directly storing pointer in SymInt"
488705c 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Aug 1, 2022
@ezyang
Replace SymIntTable with directly storing pointer in SymInt
f5530d5 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: 46c719d
Pull Request resolved: #82468
albanD
albanD reviewed Aug 1, 2022
View reviewed changes
@ezyang
Update on "Replace SymIntTable with directly storing pointer in SymInt"
def7bc4 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Aug 1, 2022
@ezyang
Replace SymIntTable with directly storing pointer in SymInt
9606123 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: 6110d2e
Pull Request resolved: #82468
albanD
albanD approved these changes Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@ezyang
Copy link
Contributor Author

ezyang commented Aug 2, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 2, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

Hey @ezyang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Aug 3, 2022
@ezyang @facebook-github-bot
Replace SymIntTable with directly storing pointer in SymInt (#82468) (#…
41c466f 
…82468)

Summary:
Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Pull Request resolved: #82468
Approved by: https://github.com/albanD

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/b2bb2251f37d96806af0dc0c63f4a3515cdc9eb3

Reviewed By: kit1980

Differential Revision: D38359571

Pulled By: ezyang

fbshipit-source-id: 4788c8c7d839a18063310b6e6780c59e48ace62c
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1299/head branch August 6, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@suo suo Awaiting requested review from suo

@Krovatkin Krovatkin Awaiting requested review from Krovatkin

@Chillee Chillee Awaiting requested review from Chillee

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ezyang @facebook-github-bot @pytorchmergebot @albanD