[primTorch] Add repeat and unfold_copy references by rdspring1 · Pull Request #81374 · pytorch/pytorch

rdspring1 · 2022-07-12T23:43:22Z

Add References:

repeat
unfold
expand_as

facebook-github-bot · 2022-07-12T23:43:29Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/81374
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit b79b179 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

soulitzer · 2022-07-15T00:32:27Z

Hey @rdspring1 do you also plan to implement the ref for repeat_interleave? I started looking into it, but realized later that you already picked up the packet.

rdspring1 · 2022-07-15T18:26:44Z

I've looked into repeat_interleave, but it isn't a high priority reference for nvfuser. I wasn't planning on implementing it in the near-term.

torch/_prims_common/__init__.py

torch/_refs/__init__.py

IvanYashchuk · 2022-08-27T16:12:28Z

@ngimel could you please take a look at this PR?

pytorch-bot · 2022-09-08T21:58:33Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/81374

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 43df14a:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Use extract_shape_from_varargs to get repeat_shape

torch/_prims_common/__init__.py

torch/_refs/__init__.py

mruberry

Cool - see small inline comments and this may require a rebase

rdspring1 · 2022-09-12T18:28:39Z

@pytorchbot merge -g

pytorchmergebot · 2022-09-12T18:31:28Z

Merge failed

Reason: Approval needed from one of the following (Rule 'superuser'):
davides, highker, xta0, bilalsal, houseroad, ...

Details for Dev Infra team

Raised by workflow job

rdspring1 · 2022-09-12T19:47:28Z

@ngimel Could you look at this?

ngimel · 2022-09-12T22:17:37Z

@pytorchbot merge -g

pytorchmergebot · 2022-09-12T22:19:02Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

github-actions · 2022-09-12T22:19:54Z

Hey @rdspring1.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Add References: - repeat - unfold - expand_as Pull Request resolved: #81374 Approved by: https://github.com/mruberry, https://github.com/ngimel

rdspring1 added 3 commits July 12, 2022 14:20

Add expand_as ref

14a93b2

Initial repeat and unfold references

70dc092

Create unfold_copy reference

5263c81

facebook-github-bot added the cla signed label Jul 12, 2022

pytorchbot added the open source label Jul 13, 2022

rdspring1 added 7 commits July 12, 2022 23:55

Use permute then reshape to avoid in-place copy operation

31ab06d

Merge branch 'master' of github.com:rdspring1/pytorch into ref_repeat

d37229b

remove expand_as decomposition

54b96d1

python refactor

9640150

Add expand_as as decomposition exception

f3223f8

Refactor to avoid calling torch empty

328c6c1

Use canonicalize_dim

fcd31dc

rdspring1 mentioned this pull request Jul 13, 2022

[primTorch] Implement batch, group, and instance norm references #81191

Closed

rdspring1 marked this pull request as ready for review July 13, 2022 23:55

rdspring1 requested review from mruberry and ngimel as code owners July 13, 2022 23:55

ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 14, 2022

rdspring1 added a commit to rdspring1/pytorch that referenced this pull request Jul 14, 2022

Add repeat reference - squashed from PR pytorch#81374

cc365e3

rdspring1 added 2 commits July 22, 2022 01:42

Merge branch 'master' of github.com:rdspring1/pytorch into ref_repeat

bc4846b

Merge branch 'master' of github.com:rdspring1/pytorch into ref_repeat

3b7aa15

IvanYashchuk added the module: primTorch label Jul 26, 2022

IvanYashchuk reviewed Jul 26, 2022

View reviewed changes

torch/_prims_common/__init__.py Outdated Show resolved Hide resolved

torch/_refs/__init__.py Outdated Show resolved Hide resolved

torch/_refs/__init__.py Outdated Show resolved Hide resolved

torch/_refs/__init__.py Show resolved Hide resolved

Merge branch 'master' of github.com:rdspring1/pytorch into ref_repeat

b79b179

Merge branch 'master' of github.com:rdspring1/pytorch into ref_repeat

53180a4

misc

7c6c598

rdspring1 added 3 commits September 8, 2022 22:47

Add expand_as to not_in_decomp_table

478b615

Use extract_shape_from_varargs to get repeat_shape

lintrunner

d3f17d5

remove aten decomp registration

fa29e99

mruberry reviewed Sep 12, 2022

View reviewed changes

torch/_prims_common/__init__.py Outdated Show resolved Hide resolved

mruberry reviewed Sep 12, 2022

View reviewed changes

torch/_refs/__init__.py Outdated Show resolved Hide resolved

mruberry approved these changes Sep 12, 2022

View reviewed changes

rdspring1 added 2 commits September 12, 2022 13:17

Merge branch 'master' of github.com:rdspring1/pytorch into ref_repeat

50adb9f

comments

43df14a

ngimel approved these changes Sep 12, 2022

View reviewed changes

pytorchmergebot added the Merged label Sep 12, 2022

pytorchmergebot closed this in d09e8b2 Sep 12, 2022

mehtanirav pushed a commit that referenced this pull request Oct 4, 2022

[primTorch] Add repeat and unfold_copy references (#81374)

9b800a7

Add References: - repeat - unfold - expand_as Pull Request resolved: #81374 Approved by: https://github.com/mruberry, https://github.com/ngimel

Conversation

rdspring1 commented Jul 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jul 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

✅ No Failures (0 Pending)

Uh oh!

soulitzer commented Jul 15, 2022

Uh oh!

rdspring1 commented Jul 15, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IvanYashchuk commented Aug 27, 2022

Uh oh!

pytorch-bot bot commented Sep 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/81374

✅ No Failures

Uh oh!

Uh oh!

Uh oh!

mruberry left a comment

Choose a reason for hiding this comment

Uh oh!

rdspring1 commented Sep 12, 2022

Uh oh!

pytorchmergebot commented Sep 12, 2022

Merge failed

Uh oh!

rdspring1 commented Sep 12, 2022

Uh oh!

ngimel commented Sep 12, 2022

Uh oh!

pytorchmergebot commented Sep 12, 2022

Uh oh!

github-actions bot commented Sep 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

rdspring1 commented Jul 12, 2022 •

edited

Loading

facebook-github-bot commented Jul 12, 2022 •

edited

Loading

pytorch-bot bot commented Sep 8, 2022 •

edited

Loading