Closed
Conversation
print_test_stats.py had a somewhat misleading name, as it was also responsible for uploading test statistics to both S3 and Scuba. We are using Rockset for most of this now, so removing the redundant code. The following are things we do *not* have replacements for: - The actual display of regressed or slow tests in the `print_test_stats` job step. I don't think people really looked at these so not a big loss. - Scuba uploads. This is sad, but fundamentally I think we probably don't want to maintain two data pipelines. [ghstack-poisoned]
Contributor
🔗 Helpful links
❌ 1 New FailuresAs of commit ae990c1 (more details on the Dr. CI page): Expand to see more
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
This was referenced Jul 9, 2022
print_test_stats.py had a somewhat misleading name, as it was also responsible for uploading test statistics to both S3 and Scuba. We are using Rockset for most of this now, so removing the redundant code. The following are things we do *not* have replacements for: - The actual display of regressed or slow tests in the `print_test_stats` job step. I don't think people really looked at these so not a big loss. - Scuba uploads. This is sad, but fundamentally I think we probably don't want to maintain two data pipelines. [ghstack-poisoned]
janeyx99
reviewed
Jul 11, 2022
Contributor
janeyx99
left a comment
There was a problem hiding this comment.
A blocker to this is the test_history.py script that the distributed team uses for test case info. Those stats read from S3 to generate a historical view across jobs--maybe an observable view would be sufficient?
cc. @pritamdamania87 (or @pritamdamania?) last time we talked, you were still using this script which was why I didn't merge #73098. Do you still use the script?
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Contributor
|
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
print_test_stats.py had a somewhat misleading name, as it was also
responsible for uploading test statistics to both S3 and Scuba.
We are using Rockset for most of this now, so removing the redundant
code.
The following are things we do not have replacements for:
print_test_statsjob step. I don't think people really looked at theseso not a big loss.
don't want to maintain two data pipelines.