Skip to content

Fix div(scalar, tensor) case for nvFuser#80341

Closed
IvanYashchuk wants to merge 2 commits intopytorch:masterfrom
IvanYashchuk:nvfuser-fix-div-scalar-lhs
Closed

Fix div(scalar, tensor) case for nvFuser#80341
IvanYashchuk wants to merge 2 commits intopytorch:masterfrom
IvanYashchuk:nvfuser-fix-div-scalar-lhs

Conversation

@IvanYashchuk
Copy link
Copy Markdown
Collaborator

This PR fixes a typo in nvFuser for div(scalar, tensor) unlocking the tests for _refs.true_divide and _refs.sigmoid.

Same PR with a C++ test to the nvFuser devel branch: csarofeen#1778.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 27, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 1e5b63b (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 27, 2022
@IvanYashchuk
Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Copy Markdown
Contributor

Hey @IvanYashchuk.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 30, 2022
Summary:
This PR fixes a typo in nvFuser for `div(scalar, tensor)` unlocking the tests for `_refs.true_divide` and `_refs.sigmoid`.

Same PR with a C++ test to the nvFuser devel branch: csarofeen#1778.

Pull Request resolved: #80341
Approved by: https://github.com/ngimel

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/471c8330432c64b41dab7483be2f1f234efe5ef3

Reviewed By: b0noI

Differential Revision: D37496033

fbshipit-source-id: 49540fb4f18ae76595aa47b043f2b3e02af96e98
jjsjann123 pushed a commit to jjsjann123/nvfuser that referenced this pull request Oct 29, 2022
This PR fixes a typo in nvFuser for `div(scalar, tensor)` unlocking the tests for `_refs.true_divide` and `_refs.sigmoid`.

Same PR with a C++ test to the nvFuser devel branch: csarofeen/pytorch#1778.
Pull Request resolved: pytorch/pytorch#80341
Approved by: https://github.com/ngimel
jjsjann123 pushed a commit to jjsjann123/nvfuser that referenced this pull request Nov 10, 2022
This PR fixes a typo in nvFuser for `div(scalar, tensor)` unlocking the tests for `_refs.true_divide` and `_refs.sigmoid`.

Same PR with a C++ test to the nvFuser devel branch: csarofeen/pytorch#1778.
Pull Request resolved: pytorch/pytorch#80341
Approved by: https://github.com/ngimel
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
This PR fixes a typo in nvFuser for `div(scalar, tensor)` unlocking the tests for `_refs.true_divide` and `_refs.sigmoid`.

Same PR with a C++ test to the nvFuser devel branch: csarofeen#1778.
Pull Request resolved: pytorch#80341
Approved by: https://github.com/ngimel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants