Skip to content

[ROCm] Remove gfx900 from base docker build and Pytorch build scripts#80015

Closed
jithunnair-amd wants to merge 1 commit intopytorch:masterfrom
jithunnair-amd:remove_gfx900
Closed

[ROCm] Remove gfx900 from base docker build and Pytorch build scripts#80015
jithunnair-amd wants to merge 1 commit intopytorch:masterfrom
jithunnair-amd:remove_gfx900

Conversation

@jithunnair-amd
Copy link
Collaborator

@jithunnair-amd jithunnair-amd commented Jun 22, 2022

CI doesn't have any MI25s anymore. Should improve docker and Pytorch build times in CI for ROCm.

Will take out of Draft mode after #79596 is merged

@pytorch-bot pytorch-bot bot added the module: rocm AMD GPU support for Pytorch label Jun 22, 2022
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 22, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 1c560e6455 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@jithunnair-amd jithunnair-amd marked this pull request as ready for review July 13, 2022 22:23
@jithunnair-amd
Copy link
Collaborator Author

jithunnair-amd commented Jul 13, 2022

@malfet Low risk PR, should improve docker and pytorch build times.

@ngimel ngimel requested a review from malfet July 14, 2022 00:33
@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 14, 2022
@jithunnair-amd
Copy link
Collaborator Author

jithunnair-amd commented Aug 2, 2022

@malfet CI checks passed. Low risk PR. Please review and approve.

@jithunnair-amd
Copy link
Collaborator Author

jithunnair-amd commented Sep 12, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 12, 2022

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 12, 2022

Successfully rebased remove_gfx900 onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout remove_gfx900 && git pull --rebase)

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 12, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/80015

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 18 Pending

As of commit 445a175:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet
Copy link
Contributor

malfet commented Sep 13, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 13, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2022

Hey @jithunnair-amd.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@jithunnair-amd @mehtanirav
[ROCm] Remove gfx900 from base docker build and Pytorch build scripts (…
57156a1 
…#80015)

CI doesn't have any MI25s anymore. Should improve docker and Pytorch build times in CI for ROCm.

Will take out of Draft mode after #79596 is merged

Pull Request resolved: #80015
Approved by: https://github.com/jeffdaily, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffdaily jeffdaily jeffdaily approved these changes

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

cla signed Merged module: rocm AMD GPU support for Pytorch open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jithunnair-amd @facebook-github-bot @pytorchmergebot @malfet @jeffdaily @ngimel @pytorchbot