Skip to content

small cleanup of executor#79973

Closed
ngimel wants to merge 1 commit intomasterfrom
ngimel/executor
Closed

small cleanup of executor#79973
ngimel wants to merge 1 commit intomasterfrom
ngimel/executor

Conversation

@ngimel
Copy link
Copy Markdown
Collaborator

@ngimel ngimel commented Jun 21, 2022

per title

@ngimel ngimel requested review from IvanYashchuk and mruberry June 21, 2022 20:43
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 21, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 025002a (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

mruberry
mruberry approved these changes Jun 22, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped!

@ngimel
Copy link
Copy Markdown
Collaborator Author

ngimel commented Jun 22, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 22, 2022

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 22, 2022

@ngimel your PR has been successfully merged.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 22, 2022

Hey @ngimel.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@ngimel ngimel added the topic: not user facing topic category label Jun 22, 2022
facebook-github-bot pushed a commit that referenced this pull request Jun 22, 2022
@facebook-github-bot
small cleanup of executor (#79973) (#79973)
4507de9 
Summary:
per title

Pull Request resolved: #79973
Approved by: https://github.com/mruberry

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/9244547a1bd639696d165993bc0592a7935d895d

Reviewed By: atalman

Differential Revision: D37343977

Pulled By: ngimel

fbshipit-source-id: 62b294cb573363089e3dd6ee9af4ce7bbc41265c
miladm pushed a commit to miladm/pytorch that referenced this pull request Jun 27, 2022
@miladm
small cleanup of executor (pytorch#79973)
03ac311 
per title
Pull Request resolved: pytorch#79973
Approved by: https://github.com/mruberry
@github-actions github-actions Bot deleted the ngimel/executor branch February 17, 2024 01:53
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@pytorchmergebot
small cleanup of executor (pytorch#79973)
a560acc 
per title
Pull Request resolved: pytorch#79973
Approved by: https://github.com/mruberry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry mruberry approved these changes

@IvanYashchuk IvanYashchuk Awaiting requested review from IvanYashchuk

Assignees

No one assigned

Labels

cla signed Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ngimel @facebook-github-bot @pytorchmergebot @mruberry