Skip to content

Explicitly convert to double for comparison#79964

Closed
kit1980 wants to merge 1 commit intomasterfrom
sdym/filler-double
Closed

Explicitly convert to double for comparison#79964
kit1980 wants to merge 1 commit intomasterfrom
sdym/filler-double

Conversation

@kit1980
Copy link
Copy Markdown
Contributor

@kit1980 kit1980 commented Jun 21, 2022

@kit1980 kit1980 requested a review from malfet June 21, 2022 19:31
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 21, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit f42567e (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@kit1980 kit1980 requested a review from a team June 21, 2022 19:32
@kit1980
Copy link
Copy Markdown
Contributor Author

kit1980 commented Jun 21, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 21, 2022

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 21, 2022

@kit1980 your PR has been successfully merged.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 21, 2022

Hey @kit1980.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 22, 2022
@kit1980 @facebook-github-bot
Explicitly convert to double for comparison (#79964) (#79964)
a21847a 
Summary:
Otherwise it errors on ONNX clang10 build: https://github.com/pytorch/pytorch/runs/6976721937?check_suite_focus=true

Pull Request resolved: #79964
Approved by: https://github.com/malfet

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e3c9cb675acbc785413973ea3268559f862eb770

Reviewed By: atalman

Differential Revision: D37333222

Pulled By: kit1980

fbshipit-source-id: 65afd02d9fce45953e849910a9d9444a3327b952
miladm pushed a commit to miladm/pytorch that referenced this pull request Jun 27, 2022
@kit1980 @miladm
Explicitly convert to double for comparison (pytorch#79964)
4e18a5c 
Otherwise it errors on ONNX clang10 build: https://github.com/pytorch/pytorch/runs/6976721937?check_suite_focus=true
Pull Request resolved: pytorch#79964
Approved by: https://github.com/malfet
@github-actions github-actions Bot deleted the sdym/filler-double branch February 17, 2024 01:53
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@kit1980 @pytorchmergebot
Explicitly convert to double for comparison (pytorch#79964)
f2194dd 
Otherwise it errors on ONNX clang10 build: https://github.com/pytorch/pytorch/runs/6976721937?check_suite_focus=true
Pull Request resolved: pytorch#79964
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kit1980 @facebook-github-bot @pytorchmergebot @malfet