[FSDP] Fix param name prefixes for ignored modules#79955
Closed
awgu wants to merge 1 commit intopytorch:masterfrom
Closed
[FSDP] Fix param name prefixes for ignored modules#79955awgu wants to merge 1 commit intopytorch:masterfrom
awgu wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit ec35a3b (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
@awgu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
Author
|
@pytorchbot merge |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
Collaborator
|
@awgu your PR has been successfully merged. |
Contributor
|
Hey @awgu. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 22, 2022
Summary: For ignored modules' parameters, we should also clean their parameter names since they will have the FSDP-specific prefixes. This change only affects the prefixed parameter name keys in `full_optim_state_dict()` (i.e. optim state dict saving). Not having this change does not actually violate the correctness of the optim state dict save-load flow because it only requires that the keys are unique and internally consistent. Either way, this PR explicitly adds the specification now that the parameter keys in the optim state dict should match the keys of full model state dict. Pull Request resolved: #79955 Approved by: https://github.com/rohan-varma Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/0b0e65516d88b6ea5ac06598dc8247afe3c21d20 Reviewed By: rohan-varma Differential Revision: D37320671 Pulled By: awgu fbshipit-source-id: 576cf28f7f744fcb75f79af1fae7a3fd2c567d89
miladm
pushed a commit
to miladm/pytorch
that referenced
this pull request
Jun 27, 2022
For ignored modules' parameters, we should also clean their parameter names since they will have the FSDP-specific prefixes. This change only affects the prefixed parameter name keys in `full_optim_state_dict()` (i.e. optim state dict saving). Not having this change does not actually violate the correctness of the optim state dict save-load flow because it only requires that the keys are unique and internally consistent. Either way, this PR explicitly adds the specification now that the parameter keys in the optim state dict should match the keys of full model state dict. Pull Request resolved: pytorch#79955 Approved by: https://github.com/rohan-varma
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
For ignored modules' parameters, we should also clean their parameter names since they will have the FSDP-specific prefixes. This change only affects the prefixed parameter name keys in `full_optim_state_dict()` (i.e. optim state dict saving). Not having this change does not actually violate the correctness of the optim state dict save-load flow because it only requires that the keys are unique and internally consistent. Either way, this PR explicitly adds the specification now that the parameter keys in the optim state dict should match the keys of full model state dict. Pull Request resolved: pytorch#79955 Approved by: https://github.com/rohan-varma
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For ignored modules' parameters, we should also clean their parameter names since they will have the FSDP-specific prefixes.
This change only affects the prefixed parameter name keys in
full_optim_state_dict()(i.e. optim state dict saving). Not having this change does not actually violate the correctness of the optim state dict save-load flow because it only requires that the keys are unique and internally consistent.Either way, this PR explicitly adds the specification now that the parameter keys in the optim state dict should match the keys of full model state dict.